Move block down to CommandCall

Author: kddnewton

CHANGELOG.md

@@ -19,6 +19,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/) a
   - `DoBlock` and `BraceBlock` have now been folded into a `Block` node. The `Block` node now has a `keywords?` method on it that returns true if the block was constructed with the `do`..`end` keywords. The `visit_do_block` and `visit_brace_block` methods on the visitor have therefore been removed and replaced with the `visit_block` method.
   - `Return0` is no longer a node. Instead if has been folded into the `Return` node. The `Return` node can now have its `arguments` field be `nil`. Consequently, the `visit_return0` method has been removed from the visitor interface. If you were previously using this method, you should now use `visit_return` instead.
 - The `ArgsForward`, `Redo`, `Retry`, and `ZSuper` nodes no longer have `value` fields associated with them (which were always string literals corresponding to the keyword being used).
+- `CommandCall` now has a `block` attribute on it. This attribute is used in the place where you would previously have a `MethodAddBlock` structure. Where before the `MethodAddBlock` would have the `CommandCall` and `Block` as its two children, you now just have one `CommandCall` node with the `block` attribute set to the `Block` node.
 
 ## [4.3.0] - 2022-10-28
 

lib/syntax_tree/node.rb

@@ -2936,6 +2936,9 @@ class CommandCall < Node
     # [nil | Args] the arguments going along with the message
     attr_reader :arguments
 
+    # [nil | Block] the block associated with this method call
+    attr_reader :block
+
     # [Array[ Comment | EmbDoc ]] the comments attached to this node
     attr_reader :comments
 
@@ -2944,13 +2947,15 @@ def initialize(
       operator:,
       message:,
       arguments:,
+      block:,
       location:,
       comments: []
     )
       @receiver = receiver
       @operator = operator
       @message = message
       @arguments = arguments
+      @block = block
       @location = location
       @comments = []
     end
@@ -2971,6 +2976,7 @@ def deconstruct_keys(_keys)
         operator: operator,
         message: message,
         arguments: arguments,
+        block: block,
         location: location,
         comments: comments
       }
@@ -3011,6 +3017,8 @@ def format(q)
           end
         end
       end
+
+      q.format(block) if block
     end
 
     private
@@ -3559,8 +3567,8 @@ def format(q)
       # If the receiver of this block a Command or CommandCall node, then there
       # are no parentheses around the arguments to that command, so we need to
       # break the block.
-      case q.parent.call
-      when Command, CommandCall
+      parent = q.parent
+      if (parent.is_a?(MethodAddBlock) && parent.call.is_a?(Command)) || parent.is_a?(CommandCall)
         q.break_parent
         format_break(q, break_opening, break_closing)
         return

lib/syntax_tree/parser.rb

@@ -1095,6 +1095,7 @@ def on_command_call(receiver, operator, message, arguments)
         operator: operator,
         message: message,
         arguments: arguments,
+        block: nil,
         location: receiver.location.to(ending.location)
       )
     end
@@ -2331,11 +2332,27 @@ def on_method_add_arg(call, arguments)
     #     Block block
     #   ) -> MethodAddBlock
     def on_method_add_block(call, block)
-      MethodAddBlock.new(
-        call: call,
-        block: block,
-        location: call.location.to(block.location)
-      )
+      case call
+      when CommandCall
+        node =
+          CommandCall.new(
+            receiver: call.receiver,
+            operator: call.operator,
+            message: call.message,
+            arguments: call.arguments,
+            block: block,
+            location: call.location.to(block.location)
+          )
+
+        node.comments.concat(call.comments)
+        node
+      else
+        MethodAddBlock.new(
+          call: call,
+          block: block,
+          location: call.location.to(block.location)
+        )
+      end
     end
 
     # :call-seq: