Merge pull request #137 from ruby-syntax-tree/handle-regexp-no-end

Handle regexp without ending better

Author: kddnewton

lib/syntax_tree/parser.rb

@@ -2837,14 +2837,21 @@ def on_regexp_end(value)
     # :call-seq:
     #   on_regexp_literal: (
     #     RegexpContent regexp_content,
-    #     RegexpEnd ending
+    #     (nil | RegexpEnd) ending
     #   ) -> RegexpLiteral
     def on_regexp_literal(regexp_content, ending)
+      location = regexp_content.location
+
+      if ending.nil?
+        message = "Cannot find expected regular expression ending"
+        raise ParseError.new(message, *find_token_error(location))
+      end
+
       RegexpLiteral.new(
         beginning: regexp_content.beginning,
         ending: ending.value,
         parts: regexp_content.parts,
-        location: regexp_content.location.to(ending.location)
+        location: location.to(ending.location)
       )
     end
 

test/parser_test.rb

@@ -41,6 +41,13 @@ def test_errors_on_missing_end_with_location
       assert_equal(4, error.column)
     end
 
+    def test_errors_on_missing_regexp_ending
+      error =
+        assert_raises(Parser::ParseError) { SyntaxTree.parse("a =~ /foo") }
+
+      assert_equal(5, error.column)
+    end
+
     def test_errors_on_missing_token_without_location
       assert_raises(Parser::ParseError) { SyntaxTree.parse(":\"foo") }
     end