From 7791cbb8cd0f4cf339f7f092b9c57d3fa55b773d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Martin=20Schro=CC=88der?= Date: Wed, 11 Feb 2015 12:17:28 +0100 Subject: [PATCH] Aligned lower/upper bound for coverage percentage interpretation for text and HTML report (according to https://phpunit.de/manual/4.5/en/appendixes.configuration.html) --- src/CodeCoverage/Report/HTML/Renderer.php | 4 ++-- src/CodeCoverage/Report/Text.php | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/CodeCoverage/Report/HTML/Renderer.php b/src/CodeCoverage/Report/HTML/Renderer.php index fda6f4ba8..237a1d1a7 100644 --- a/src/CodeCoverage/Report/HTML/Renderer.php +++ b/src/CodeCoverage/Report/HTML/Renderer.php @@ -259,9 +259,9 @@ protected function getCoverageBar($percent) */ protected function getColorLevel($percent) { - if ($percent < $this->lowUpperBound) { + if ($percent <= $this->lowUpperBound) { return 'danger'; - } elseif ($percent >= $this->lowUpperBound && + } elseif ($percent > $this->lowUpperBound && $percent < $this->highLowerBound) { return 'warning'; } else { diff --git a/src/CodeCoverage/Report/Text.php b/src/CodeCoverage/Report/Text.php index 81b9ef2bd..6a4d43400 100644 --- a/src/CodeCoverage/Report/Text.php +++ b/src/CodeCoverage/Report/Text.php @@ -219,7 +219,7 @@ protected function getCoverageColor($numberOfCoveredElements, $totalNumberOfElem $numberOfCoveredElements, $totalNumberOfElements ); - if ($coverage > $this->highLowerBound) { + if ($coverage >= $this->highLowerBound) { return $this->colors['green']; } elseif ($coverage > $this->lowUpperBound) { return $this->colors['yellow'];