Saving raw JSON through MongoTemplate.insert(…) fails [DATAMONGO-771]

[spring-projects-issues]

Frank Tyler opened DATAMONGO-771 and commented

There doesn't seem to be a straight forward way to save raw json as a document. This is desired for cases where you receive raw json as a payload (Spring Integration, Spring XD)

---

Backported to: 1.3.2 (Babbage SR1)

[spring-projects-issues]

Thomas Darimont commented

Hello Frank,

can you give us a short example for the API you are looking for?

...or does this work for you:

DBObject dbObject = (DBObject) JSON.parse("{'name':'mkyong', 'age':30}");
//save dbObject with mongoTemplate

Cheers Thomas

[spring-projects-issues]

Oliver Drotbohm commented

Even simpler, plain String object, passed to MongoTemplate.save(…) are interpreted as JSON document, so you can simply call:

template.save("{'name':'mkyong', 'age':30}", "myCollection");

[spring-projects-issues]

Frank Tyler commented

I think the save method with just a String and collection name would better encapsulate the conversion to DBObject

[spring-projects-issues]

Oliver Drotbohm commented

As I wrote, this is what MongoTemplate.save(Object payload, String collectionName) does right now. So what do you think can be improved in this regard?

[spring-projects-issues]

Frank Tyler commented

Sorry for the confusion. The following code should explain the issue:

mongo = new Mongo( "127.0.0.1", 27017 );
SimpleMongoDbFactory factory = new SimpleMongoDbFactory( mongo, "test" );
MongoTemplate template = new MongoTemplate(factory);
String json = "{"name":"mkyong", "age":30}";
template.save( json, "myCollection" );

Which ends up storing a document with just an _id field.

{ "_id" : ObjectId("524ec13f30041e674ea96992") }

I also tried the insert method which errors out with the following exception.

Exception in thread "main" org.springframework.data.mapping.model.MappingException: No mapping metadata found for entity of type java.lang.String
at org.springframework.data.mongodb.core.convert.MappingMongoConverter.writeInternal(MappingMongoConverter.java:345)
at org.springframework.data.mongodb.core.convert.MappingMongoConverter.writeInternal(MappingMongoConverter.java:334)
at org.springframework.data.mongodb.core.convert.MappingMongoConverter.write(MappingMongoConverter.java:299)
at org.springframework.data.mongodb.core.convert.MappingMongoConverter.write(MappingMongoConverter.java:72)
at org.springframework.data.mongodb.core.MongoTemplate.doInsert(MongoTemplate.java:663)
at org.springframework.data.mongodb.core.MongoTemplate.insert(MongoTemplate.java:622)
at com.novetta.mongodb.MongoTest.main(MongoTest.java:24)

I think in both cases, it should just persist the JSON string passed into the method as is.

-Frank

[spring-projects-issues]

Frank Tyler commented

After further testing, I think the only issue is with the insert method, which isn't handling String types the same way the save method does. It turns out I was using the 1.1.1 release and not the latest snapshot. I guess this should be an defect instead of an improvement

[spring-projects-issues]

Oliver Drotbohm commented

We should extract the String handling code in doSave(…) and also use it from doInsert(…)

[spring-projects-issues]

Thomas Darimont commented

Added PR: #79

[spring-projects-issues]

Thomas Darimont commented

Please revise