Remove DOM dependency from XML report generation

Author: staabm

src/Report/Xml/BuildInformation.php

@@ -9,74 +9,62 @@
  */
 namespace SebastianBergmann\CodeCoverage\Report\Xml;
 
-use function assert;
+use XMLWriter;
 use function phpversion;
 use DateTimeImmutable;
-use DOMElement;
 use SebastianBergmann\Environment\Runtime;
 
 /**
  * @internal This class is not covered by the backward compatibility promise for phpunit/php-code-coverage
  */
 final readonly class BuildInformation
 {
-    private DOMElement $contextNode;
-
-    public function __construct(DOMElement $contextNode)
-    {
-        $this->contextNode = $contextNode;
-    }
+    private Runtime $runtime;
+    private DateTimeImmutable $buildTime;
+    private string $phpunitVersion;
+    private string $coverageVersion;
 
     public function setRuntimeInformation(Runtime $runtime): void
     {
-        $runtimeNode = $this->nodeByName('runtime');
-
-        $runtimeNode->setAttribute('name', $runtime->getName());
-        $runtimeNode->setAttribute('version', $runtime->getVersion());
-        $runtimeNode->setAttribute('url', $runtime->getVendorUrl());
-
-        $driverNode = $this->nodeByName('driver');
-
-        if ($runtime->hasXdebug()) {
-            $driverNode->setAttribute('name', 'xdebug');
-            $driverNode->setAttribute('version', phpversion('xdebug'));
-        }
-
-        if ($runtime->hasPCOV()) {
-            $driverNode->setAttribute('name', 'pcov');
-            $driverNode->setAttribute('version', phpversion('pcov'));
-        }
+        $this->runtime = $runtime;
     }
 
     public function setBuildTime(DateTimeImmutable $date): void
     {
-        $this->contextNode->setAttribute('time', $date->format('D M j G:i:s T Y'));
+        $this->buildTime = $date;
     }
 
     public function setGeneratorVersions(string $phpUnitVersion, string $coverageVersion): void
     {
-        $this->contextNode->setAttribute('phpunit', $phpUnitVersion);
-        $this->contextNode->setAttribute('coverage', $coverageVersion);
+        $this->phpunitVersion = $phpUnitVersion;
+        $this->coverageVersion = $coverageVersion;
     }
 
-    private function nodeByName(string $name): DOMElement
+    public function write(XMLWriter $writer): void
     {
-        $node = $this->contextNode->getElementsByTagNameNS(
-            Facade::XML_NAMESPACE,
-            $name,
-        )->item(0);
+        $writer->startElement('build');
+        $writer->writeAttribute('time', $this->buildTime->format('D M j G:i:s T Y'));
+        $writer->writeAttribute('phpunit', $this->phpunitVersion);
+        $writer->writeAttribute('coverage', $this->coverageVersion);
 
-        if ($node === null) {
-            $node = $this->contextNode->appendChild(
-                $this->contextNode->ownerDocument->createElementNS(
-                    Facade::XML_NAMESPACE,
-                    $name,
-                ),
-            );
-        }
+        $writer->startElement('runtime');
+        $writer->writeAttribute('name', $this->runtime->getName());
+        $writer->writeAttribute('version', $this->runtime->getVersion());
+        $writer->writeAttribute('url', $this->runtime->getVendorUrl());
+        $writer->endElement();
 
-        assert($node instanceof DOMElement);
+        $writer->startElement('driver');
+        if ($this->runtime->hasXdebug()) {
+            $writer->writeAttribute('name', 'xdebug');
+            $writer->writeAttribute('version', phpversion('xdebug'));
+        }
+        if ($this->runtime->hasPCOV()) {
+            $writer->writeAttribute('name', 'pcov');
+            $writer->writeAttribute('version', phpversion('pcov'));
+        }
+        $writer->endElement();
 
-        return $node;
+        $writer->endElement();
     }
+
 }

src/Report/Xml/Facade.php

@@ -9,6 +9,7 @@
  */
 namespace SebastianBergmann\CodeCoverage\Report\Xml;
 
+use XMLWriter;
 use const DIRECTORY_SEPARATOR;
 use function count;
 use function dirname;
@@ -47,10 +48,13 @@ final class Facade
     private string $target;
     private Project $project;
     private readonly string $phpUnitVersion;
+    private XMLWriter $xmlWriter;
 
     public function __construct(string $version)
     {
         $this->phpUnitVersion = $version;
+        $this->xmlWriter = new XMLWriter();
+        $this->xmlWriter->openMemory();
     }
 
     /**
@@ -84,6 +88,7 @@ private function setBuildInformation(): void
         $buildNode->setRuntimeInformation(new Runtime);
         $buildNode->setBuildTime(new DateTimeImmutable);
         $buildNode->setGeneratorVersions($this->phpUnitVersion, Version::id());
+        $buildNode->write($this->xmlWriter);
     }
 
     /**

src/Report/Xml/Node.php

@@ -9,6 +9,7 @@
  */
 namespace SebastianBergmann\CodeCoverage\Report\Xml;
 
+use XMLWriter;
 use function assert;
 use DOMDocument;
 use DOMElement;

src/Report/Xml/Project.php

@@ -9,6 +9,7 @@
  */
 namespace SebastianBergmann\CodeCoverage\Report\Xml;
 
+use XMLWriter;
 use function assert;
 use DOMDocument;
 use DOMElement;
@@ -34,23 +35,7 @@ public function projectSourceDirectory(): string
 
     public function buildInformation(): BuildInformation
     {
-        $buildNode = $this->dom()->getElementsByTagNameNS(
-            Facade::XML_NAMESPACE,
-            'build',
-        )->item(0);
-
-        if ($buildNode === null) {
-            $buildNode = $this->dom()->documentElement->appendChild(
-                $this->dom()->createElementNS(
-                    Facade::XML_NAMESPACE,
-                    'build',
-                ),
-            );
-        }
-
-        assert($buildNode instanceof DOMElement);
-
-        return new BuildInformation($buildNode);
+        return new BuildInformation();
     }
 
     public function tests(): Tests