Cant insert into table PHP MySQL

Question

I have the following php query...

INSERT INTO `demographic2` (id, name, first_name, last_name, link, username, birthday, gender, relationship_status, email, timezone, locale, verified, updated_time) VALUES (845450180, Liam Gallagher, Liam, Gallagher, http://www.facebook.com/lia.co.uk, lia.co.uk, 11/25/1989, male, Single, [email protected], 1, en_US, 1, 2012-03-30T21:54:17+0000)

I cant see any errors but for some reason the above wont insert data into my table, the schema looks like so...

enter image description here

Regarding string literals, I have this as my insert query, How would i add the quotes?

$columns = implode(", ",array_keys($userInfo));
            $escaped_values = array_map('mysql_real_escape_string', array_values($userInfo));
            $values  = implode(", ", $escaped_values);
            $sql = "INSERT INTO `demographic2` ($columns) VALUES ($values)";

You need to write strings inside quote, like VALUES ('845450180', 'Liam Gallagher'... — safarov
– safarov, Commented Apr 7, 2012 at 14:01

Crozin · Accepted Answer · 2012-04-07 14:02:31Z

2

Read about string literals in MySQL. You have to write strings in quotes, eg: "my text".

answered Apr 7, 2012 at 14:02

Crozin

44.5k13 gold badges92 silver badges136 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Kristian Glass · Accepted Answer · 2012-04-07 15:33:46Z

2

You should wrap your string value with "" or '', e.g. "value" or 'value'.

You can also read more about anti-SQL-injection techniques to create an SQL query string better at http://www.unixwiz.net/techtips/sql-injection.html

edited Apr 7, 2012 at 15:33

Kristian Glass

38.7k7 gold badges50 silver badges74 bronze badges

answered Apr 7, 2012 at 14:05

Nguyễn Hoàng Gia

9284 silver badges11 bronze badges

Comments

Haywire · Accepted Answer · 2012-04-07 14:17:44Z

1

you can try enclosing ', ' as glue into the implode() in the second use, so it becomes:

$columns = implode(", ",array_keys($userInfo));
            $escaped_values = array_map('mysql_real_escape_string', array_values($userInfo));
            $values  = implode("', '", $escaped_values);
            $sql = "INSERT INTO `demographic2` ({$columns}) VALUES ('{$values}')";

edited Apr 7, 2012 at 14:17

answered Apr 7, 2012 at 14:07

Haywire

8784 gold badges14 silver badges30 bronze badges

Comments

Arion · Accepted Answer · 2012-04-07 14:03:48Z

1

I think you need to add 'SomevarcharOrDatetime'

INSERT INTO `demographic2` 
(
  id, name, 
  first_name, 
  last_name, 
  link, 
  username, 
  birthday, 
  gender, 
  relationship_status, 
  email, 
  timezone, 
  locale, 
  verified, 
  updated_time
) 
VALUES 
(
  845450180, 
  'Liam Gallagher', 
  'Liam', 
  'Gallagher', 
  'http://www.facebook.com/lia.co.uk', 
  'lia.co.uk', 
  '11/25/1989', 
  'male', 
  'Single', 
  '[email protected]', 
  1, 
  'en_US', 
  1, 
  '2012-03-30T21:54:17+0000'
)

answered Apr 7, 2012 at 14:03

Arion

31.3k10 gold badges74 silver badges89 bronze badges

Comments

Steve · Accepted Answer · 2012-04-07 14:06:23Z

1

Nothing is quoted.

INSERT INTO `demographic2` (id, name, first_name, last_name, link, username, birthday, gender, relationship_status, email, timezone, locale, verified, updated_time)
VALUES (845450180, "Liam Gallagher", "Liam", "Gallagher", "http://www.facebook.com/lia.co.uk", "lia.co.uk", "11/25/1989", "male", "Single", "[email protected]", "1", "en_US", "1", "2012-03-30T21:54:17+0000")

Also, why aren't you using DATE columns for dates (birthday)?

answered Apr 7, 2012 at 14:06

Steve

7,1683 gold badges47 silver badges42 bronze badges

Comments

Pruthvithej · Accepted Answer · 2012-04-07 14:18:03Z

0

Use custom function to map each value & apply single quote to escaped string.

$columns = implode(", ",array_keys($userInfo));
$escaped_values = array_map('escape_inpt_string', array_values($userInfo));
$values  = implode(", ", $escaped_values);
$sql = "INSERT INTO `demographic2` ($columns) VALUES ($values)";

function escape_inpt_string($val) {
  return "'".mysql_real_escape_string($val)."'";
}

Cheers!!

answered Apr 7, 2012 at 14:18

Pruthvithej

211 bronze badge

Collectives™ on Stack Overflow

Cant insert into table PHP MySQL

6 Answers 6

Comments

Comments

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

6 Answers 6

Comments

Comments

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related