PHP Preg_replace youtube link into embed link

Question

Okay everyone, I have found multiple ways of doing this and I have even got it to work but my issue is this, the preg_replace from my understanding should replace everything that matches the pattern but it appears to only run once.

Here is what I need, I have a site that is running a feature that let's users post whatever they want on their profile, we want to let them also post youtube links and have these links turn into embeds. The problem arises when they post more then one video, it will only embed one of the videos and worse it removes the text.

$test = "This is a great lecture: http://www.youtube.com/watch?v=Ps8jOj7diA0 This is another great lecture http://www.youtube.com/watch?v=k6U-i4gXkLM What are your opinions on the two?"
$patterns[] = '|http://www\.youtube\.com/watch\?.*\bv=([^ ]+)|';
$replacements[] = ' <br /><iframe width="420" height="315" src=http://www.youtube.com/embed/$1 frameborder="0" allowfullscreen></iframe><br />';
$patterns[] = '|&feature=related|';
$replacements[] = '';
$test = preg_replace($patterns, $replacements, $test);
echo $test;
Output:
"This is a great lecture: 
<iframe width="420" height="315" src=http://www.youtube.com/embed/k6U-i4gXkLM frameborder="0" allowfullscreen></iframe>
What are your opinions on the two?"

So you see... It cuts out everything between the first and second video and only embeds the second video. I need a solution that will let me remove the extra stuff produced by youtube links and also keep all the text of the messages that users post. Any idea's guys? Thanks.

You really shouldn't use | as your regex delimiter. Pretty much everyone expect it to have the common meaning of "or" in a regex. — ThiefMaster
– ThiefMaster, Commented Apr 25, 2012 at 21:47

Jack · Accepted Answer · 2012-04-25 21:46:17Z

2

Make it non-greedy.

http://www\.youtube\.com/watch\?.*?\bv=([^ ]+)

Note the extra ? here ?.*? from http://www\.youtube\.com/watch\?.*\bv=([^ ]+)

answered Apr 25, 2012 at 21:46

Jack

5,85812 gold badges52 silver badges76 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Lix Over a year ago

Its like spot the difference :P

besimple · Accepted Answer · 2013-12-04 21:50:09Z

0

There are two problems with Jack's code: - it does not properly catch links that are at the end of a line (\n character) - it does not remove optional additional parameters (eg. &list=...)

Here is the complete code:

$test = "This is a great lecture: http://www.youtube.com/watch?v=Ps8jOj7diA0&list=PL33AFE53E080251DF This is another great lecture http://www.youtube.com/watch?v=k6U-i4gXkLM What are your opinions on the two?"
$patterns = array('|http://www\.youtube\.com/watch\?.*?\bv=([^&]+).+?\s|i');
$replacements = array(' <br /><iframe width="400" height="300" src="http://www.youtube.com/embed/$1" frameborder="0" allowfullscreen></iframe><br />');
$test= preg_replace($patterns, $replacements, $test);

edited Dec 4, 2013 at 21:50

answered Dec 4, 2013 at 13:08

besimple

4431 gold badge7 silver badges13 bronze badges

Collectives™ on Stack Overflow

PHP Preg_replace youtube link into embed link

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related