Two simple mysql query

Question

I'm a noob when it comes to mysql and php, and just want to ask if I do this correct:

I want to SELECT from a table where "lastTurn" is more then 12h. Is this the correct way to do it. I'm most concernt with the 12h time stamp

$queryQuit = mysql_query("SELECT match_id, lastTurn FROM active_matches WHERE matchStatus=0 AND noticeSent < 2 AND lastTurn < NOW() - INTERVAL 12 HOUR");

I use Asihttprequest to send data to the server. If I send an int, do I need to convert it before it goes into the database?

//score is an int
$score = mysql_real_escape_string($_POST['score']); 

//Update a table where the field is an int 
 "UPDATE hiscore SET score=score + '$score' WHERE username='$username'"

Thanks in advance

Question 2: yes, convert it to an int ($score = (int) $_POST['score']; instead of your escape line) and remove the apostrophes from around $score in the UPDATE statement. — halfer
– halfer, Commented Apr 28, 2012 at 21:44
Thanks. Is there something that can go wrong with the apostrophes, or is it just unnecessarily? — BlackMouse
– BlackMouse, Commented Apr 28, 2012 at 21:55
It's unnecessary. It'll probably still work, but your database will read it as a string, and then realise it can be converted to a number due to the column type, rather than converting it to a number immediately. — halfer
– halfer, Commented Apr 28, 2012 at 21:58
So I should skip the apostrophes for int values, and keep it if I know the variable is a string? Correct! — halfer
– halfer, Commented Apr 28, 2012 at 22:02
That said, it is better to use the PDO approach, so you can use value parameterisation. The mysql module is quite old these days. — halfer
– halfer, Commented Apr 28, 2012 at 22:03

ilanco · Accepted Answer · 2012-04-28 21:46:56Z

1

This looks correct
You need to cast to int if you want to make sure you are saving an integer

Code example:

$score = mysql_real_escape_string((int) $_POST['score']);

or

$score = mysql_real_escape_string(intval($_POST['score']));

answered Apr 28, 2012 at 21:46

ilanco

10.1k4 gold badges34 silver badges37 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Two simple mysql query

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related