python assigning variable mess

Question

I'm trying to write a script that 1. lists the content of a directory, creates a list of it(temp.txt), turns the list into a string and writes it into a file 2. opens an other text file(t.txt) and compares the content of the opened file with the previously saved file (temp.txt) and returns the difference. The idea is that the script would be able to tell if there are new files in a folder. The function dif works great as a standalone script but when nested as a function I get this error message:

Enter directory >  /users
Traceback (most recent call last):
  File "/Users/alkopop79/NetBeansProjects/comparefiles.py", line 33, in <module>
    dir()
  File "/Users/alkopop79/NetBeansProjects/comparefiles.py", line 12, in dir
    li.append(fname)
UnboundLocalError: local variable 'li' referenced before assignment

and the script:

import os

li = []
lu = []
le = []

def dir():
    dir = raw_input("Enter directory >  ")
    path=dir  # insert the path to the directory of interest
    dirList=os.listdir(path)
    for fname in dirList:
            li.append(fname)
    li = ','.join(str(n) for n in li)   
    targetfile = open("temp.txt", 'w')
    targetfile.write(li)
    targetfile.close() 
    print li

def open_file():
    txt = open('t.txt')
    li = txt.read()
    la = li.split()
    return la
    print len(li)

def open_another():
    txt = open('temp.txt')
    lu = txt.read()
    lo = lu.split()
    return lo
    print len(li)

dir()
a = open_file()
b = open_another()
print set(a) & set(b)

My basic advice would be to avoid using global variables (li, lu, le). Remember that a Python function can accept arguments and can return one or more values. — NPE
– NPE, Commented May 14, 2012 at 10:08
dir is the name of a built-in function, which ought not be hidden like this. — Karl Knechtel
– Karl Knechtel, Commented May 14, 2012 at 10:46

ubik · Accepted Answer · 2012-05-14 10:17:57Z

1

Use global li inside your functions. From what I understand, the Python interpreter will look for globals at the global scope only if it cannot find them locally. It is enough that they are set somewhere in the local method (even if it's after a possible "read") for the interpreter to bind them to local scope, thus ignoring any global declaration and resulting in the error that you see.

For instance:

a = 3

def b():
    print a
    a = 1

Will fail, even though a is defined globally at the time the print statement is executed. Adding global a at the beginning of the function body would make it work.

edited May 14, 2012 at 10:17

answered May 14, 2012 at 10:10

ubik

4,5802 gold badges25 silver badges30 bronze badges

Sign up to request clarification or add additional context in comments.

7 Comments

NPE Over a year ago

While this can be used to solve the OP's problem, I don't think this is terribly good advice in the longer term. I think it's far better to avoid global variables in the first place (especially in as simple a case as this one).

ubik Over a year ago

@aix: totally agree, but I'm trying to provide an insight on why the error happens in the first place.

alkopop79 Over a year ago

Thanks for your thoughts, it's all very helpful!

alkopop79 Over a year ago

and alas, it worked! just had to declare the variable in the function! Yey!

OmnipotentEntity Over a year ago

Declaring it in the function is the proper way to handle this issue. Avoid global variables. If you need a persistent variable (which you don't in this case), then you should be looking at object encapsulation.

|

Karl Knechtel · Accepted Answer · 2012-05-14 11:04:31Z

There are numerous conceptual problems here. For the sake of actually teaching something, I've gone over the code completely:

A print after an unconditional return can't be reached; I guess you had these in for debugging, but there's no point keeping them around. (I'm assuming print li from dir is not really needed either.)
Your function names should do a better job of indicating what the function actually does. open_file is a useless name, since the function actually does something with the file's contents.
Variable names, similarly, ought to indicate the meaning of the variable's contents. If you can't come up with a good name, it's a sign that the variable is unnecessary. Another sign is that you store the value once and then use it once; the only reason to involve a variable here is to break up an expression and give something a name, but here you have simple expressions and no good names. So just write out a single expression.
You presumably want to write the directory list as a list of lines, so join them with newlines, not commas.
There are even simpler ways to get a list of the lines in a file, than reading the entire file and splitting up the resulting string. They'll generally be more efficient, too. In fact, you don't need to construct the list and then build a set from the list; you can create the set directly.
open_file and open_another perform the same task, and thus are redundant. Just pass in a filename and use it.
Try to separate responsibilities of functions into logical blocks. In particular, don't handle I/O in the same place that you do the calculations.
In modern Python, we use with blocks to handle automatically closing the file when we're done with it.
os.listdir already creates a list, so there is no reason to make a loop to append the list items to another list. You could, for example, append the whole thing at once with +; but your apparent intent is to append to an empty list, so you could just assign directly. In fact, there is no need for the global variable or the assignment, so we'll just use the os.listdir result directly.

Your program can be this simple:

import os

def make_dirfile(directory):
    with open('temp.txt', 'w') as dirfile:
        dirfile.write('\n'.join(os.listdir(directory)))

def unique_lines_of(filename):
    with open(filename) as input_file:
        return set(input_file)

make_dirfile(raw_input("Enter directory >  "))
print unique_lines_of('temp.txt') & unique_lines_of('t.txt')

(And that assumes that creating the directory file is actually a requirement...)

docs.python.org/whatsnew/2.5.html#pep-343-the-with-statement is the best summary I can find quickly, although it's probably more information than you need or want. Depending on what exactly you mean by "how", anyway.

Collectives™ on Stack Overflow

python assigning variable mess

2 Answers 2

7 Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

7 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related