Unexpected T_ELSE in php code

Question

I'm a newbie in php programming and i can't make it finding where is the error in this piece of code:

<p>
       <?php
            function check_input($data)
                {
                    $data = trim($data);
                    $data = stripslashes($data);
                    $data = htmlspecialchars($data);
                    $data = nl2br($data);
                    return $data;
                }
            $password = $_POST['password'];//security check on the input of the password

            if (isset($password))
            {
                if ($password == "hotdog")
                {
       ?>
                    Here is the secret NASA code: <br/>
                    <strong>RT4567EGST442YT3ZQS</strong>
       <?php
                else
                {
       ?>
                    The password is incorrect. <br/>
                    <a href="index.php">go and try here again</a>.
       <?php
                }
                }
            }
            else
            {
       ?>
                You have to put a password. thanks to retry on <a href="index.php">this page</a>.
       <?php
            }
       ?>
   </p>

Any help will be appreciated! thanks a lot. Mike

You might be better with heredoc instead of all those nested <?php ?> tags... php.net/manual/en/… — Adam
– Adam, Commented Jun 20, 2012 at 0:03

Asaph · Accepted Answer · 2012-06-20 00:03:01Z

2

Near line 21 in the code you posted, you're missing a }. Change

    <?php
            else
            {

    ?>

to

    <?php
            } else
            {
    ?>

answered Jun 20, 2012 at 0:03

Asaph

163k25 gold badges204 silver badges204 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

edwardmp · Accepted Answer · 2012-06-20 00:12:19Z

1

You also added a } too much on line 28.

This should work:

    <p>
   <?php
    function check_input($data)
        {
            $data = trim($data);
            $data = stripslashes($data);
            $data = htmlspecialchars($data);
            $data = nl2br($data);
            return $data;
        }

        $password = $_POST['password'];//security check on the input of the password

        if (isset($password))
        {
            if ($password == "hotdog")
            {
   ?>
                Here is the secret NASA code: <br/>
                <strong>RT4567EGST442YT3ZQS</strong>
   <?php
            }
            else
            {
   ?>
                The password is incorrect. <br/>
                <a href="index.php">go and try here again</a>.
   <?php
            }
        }
        else
        {
   ?>
            You have to put a password. thanks to retry on <a href="index.php">this page</a>.
   <?php
        }
   ?></p>

answered Jun 20, 2012 at 0:12

edwardmp

6,6316 gold badges53 silver badges80 bronze badges

4 Comments

Mathieu Over a year ago

i think i will also check out heredoc and nowdoc as suggested by Adam php.net/manual/en/…

edwardmp Over a year ago

You should, but that has nothing to do with your question.

Mathieu Over a year ago

i'm new here on stackoverflow. i've pu that the "feedback was useful". How can i "mark it" if the answer is right. thanks

Mathieu Over a year ago

ok i had not spotted the place under the figure where i can 'tick' the correct answer. thanks.

Collectives™ on Stack Overflow

Unexpected T_ELSE in php code

2 Answers 2

Comments

4 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

4 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related