Django: include other urlpatterns in a single urls.py

Question

I am doing something like this in myproject.myapp.urls:

from django.conf.urls.defaults import *

urlpatterns = patterns('myproject.myapp.views',
    (ur'^$', 'index'),
    (ur'^browse/$', 'browse'),
    (ur'^request/new/$', 'new_request'),
    (ur'^(?P<url_key>[-a-zA-Z0-9]+)/$', 'view1'),
    (ur'^(?P<url_key>[-a-zA-Z0-9]+)/asdf$', 'view2'),
    (ur'^(?P<url_key>[-a-zA-Z0-9]+)/qwer$', 'view3'),
    (ur'^(?P<url_key>[-a-zA-Z0-9]+)/zxcv$', 'view4'),
    (ur'^(?P<url_key>[-a-zA-Z0-9]+)/tyui$', 'view5'),
    (ur'^(?P<url_key>[-a-zA-Z0-9]+)/ghjk$', 'view6'),
    (ur'^(?P<url_key>[-a-zA-Z0-9]+)/bnm/more-looong-url/$', 'view7'),
    ...
)

I've tried to refactor above rules and define them in another file urls2.py like this:

(ur'^(?P<url_key>[-a-zA-Z0-9]+)/', include('myproject.myapp.urls2')),

but it seems to cause problems with unit tests including urlresolvers.

Is there better way to "refactor" the common part of regular expression (<url_key>) here?

What problems did it cause? Using include('') is usually pretty straightforward. Could you describe the errors it gave, or how the output differed from what you were expecting? — anschauung
– anschauung, Commented Jul 15, 2009 at 2:15

Dan Breen · Accepted Answer · 2009-07-15 02:15:56Z

3

I'm no django expert, but wouldn't the 'view1' item match all of the other entries below it since it doesn't have a '$' at the end? So the other views wouldn't have a chance to get matched.

answered Jul 15, 2009 at 2:15

Dan Breen

13k4 gold badges40 silver badges49 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Soviut Over a year ago

+1 put the catch-all at the end or just include $ for every url.

Wogan · Accepted Answer · 2009-07-15 02:30:32Z

2

I don't think you can do what you are trying to do with this line:

(ur'^(?P<url_key>[-a-zA-Z0-9]+)/', include('myproject.myapp.urls2'))

What view is the url_key parameter going to be passed to?

I'm not sure why you want to refactor the urlpatterns to begin with, but maybe this would be better?:

from django.conf.urls.defaults import *

URL_KEY = ur'^(?P<url_key>[-a-zA-Z0-9]+)'

urlpatterns = patterns('myproject.myapp.views',
    (ur'^$', 'index'),
    (ur'^browse/$', 'browse'),
    (ur'^request/new/$', 'new_request'),
    (URL_KEY+ur'/$', 'view1'),
    (URL_KEY+ur'/asdf$', 'view2'),
    (URL_KEY+ur'/qwer$', 'view3'),
    ...etc
)

answered Jul 15, 2009 at 2:30

Wogan

73k5 gold badges37 silver badges36 bronze badges

1 Comment

Achimnol Over a year ago

Well, I've fixed my test problems and adopted my original solution still, but this is a good suggestion. So I choose this as answer. :)

anschauung · Accepted Answer · 2009-07-15 02:21:30Z

0

Perhaps you could simplify the expressions in myproject.myapp.urls, and instead pass the information along as a parameter to a function in myproject.myapp.views?

I'm not sure what was going wrong in your tests, but generally speaking you'll be able to do more in myproject.myapp.views since you don't have to base it all on regex logic.

That function in myproject.myapp.views would be a switchboard that calls view1, view2, etc

answered Jul 15, 2009 at 2:21

anschauung

3,7683 gold badges27 silver badges35 bronze badges

Collectives™ on Stack Overflow

Django: include other urlpatterns in a single urls.py

3 Answers 3

1 Comment

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related