append parameters to URL, avoid duplicates

Question

I have a script that searches through urls and looks for a certain domain name, then appends some parameters to the end of the url. However, if run more than once, it will add duplicate parameters to the same url. Is it possible check if the url already has parameters on it?

JSFiddle

original stackoverflow post

code being modified

<div id="wp-content-editor-container" class="wp-editor-container"><textarea class="wp-editor-area" rows="10" tabindex="1" cols="40" name="content" id="content">&lt;a title="Link to test domain" href="http://www.domain.com"&gt;Link to google&lt;/a&gt;
&lt;a href="http://google.com/directory/subdirectory/index.html"&gt;This is another link&lt;/a&gt;
&lt;a href="http://domain.com/directory/index.html"&gt;This is a 3rd link&lt;/a&gt;

&lt;a href="http://www.domain.com/subdir?parameter"&gt;this url already has parameters&lt;/a&gt;</textarea></div>

jquery script

var url = 'www.domain.com';
var append = '?parameter';

$(".wp-editor-area").each(function() {
    $(this).text(urlify($(this).text()));
});

function urlify(text) {
    var urlRegex = /(\b(https?|ftp|file):\/\/[www.domain.com][-A-Z0-9+&@#\/%?=~_|!:,.;]*[-A-Z0-9+&@#\/%=~_|])/ig;
    return text.replace(urlRegex, function(url) {
        return url + append;
    })
}

current output

<a title="Link to test domain" href="http://www.domain.com?parameter">Link to google</a>
<a href="http://google.com/directory/subdirectory/index.html">This is another link</a>
<a href="http://domain.com/directory/index.html?parameter">This is a 3rd link</a>

<a href="http://www.domain.com/subdir?parameter?parameter">this url already has parameters</a>

The ideal output would not add a second "?parameter" at the end of the url ^

Thanks!

isn't this just a matter of checking if the parameter string is in the full url or not? If it is then don't add it, else add parameter — Huangism
– Huangism, Commented Jul 11, 2012 at 20:32

james31rock · Accepted Answer · 2012-07-11 20:41:39Z

2

I think you can use indexOf to check if the URL already contains what you are trying to append.

  function urlify(text) {
                var urlRegex = '/(\b(https?|ftp|file):\/\/[www.domain.com][-A-Z0-9+&@#\/%?=~_|!:,.;]*[-A-Z0-9+&@#\/%=~_|])/ig';
                return text.replace(urlRegex, function (url) {
                    // if the url does not contain append, concat append to the URL
                    if (url.indexOf(append) == -1) {
                        return url + append;
                    }
                    return url;
                });

answered Jul 11, 2012 at 20:41

james31rock

2,7152 gold badges22 silver badges25 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

DirkDiggler Over a year ago

i was mistaken earlier and deleted the comment. Original answer works beautifully thank you! Much easier than searching through the url.

Collectives™ on Stack Overflow

append parameters to URL, avoid duplicates

1 Answer 1

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related