Java Generics & Polymorphism

Question

I had an error while generalizing some classes in order to reduce code duplicates in my project, the case is as follows:

interface ClassRoot{}

public class ClassChild1 implements ClassRoot{
    // constructor is omitted for simplicity
    public Collection<ClassChild1> createList(){

        Collection<ClassChild1> col = getCollectionFromSomewhere();
        return col;
    }
}

public class Class1{
    protected <T extends ClassRoot> Collection<T> doSth(){
        Collection<T> myCol = null;
        ClassChild1 child = new ClassChild1();

        // here I get compile time assignment error
        // also (assuming that myCol not null) myCol.add(new ClassChild1());
        // is not permitted.
        myCol = child.createList();
        return myCol;
    }
}

Isn't that against the polymorphism phenomenon? I know that for example,

List<Object> list1;

can never be (and should not be assigned for typesafety) to:

List<String> list2;

But here my case is different, i specified the Type Parameter extending some specific class expecting to make use of OOP Polymorphism concept, and doing assignments right exactly implementing right class. Now I have 2 questions;

May someone clearly explain why is that is forbidden in Java, for what justifiable reason?
How can I implement such a functionality, by using type params or wildcards?

createList() should return a Collection<ClassChild1> not a ClassChild1. Don't you have a compile error for this? For clarity you should explain your error in your question, not just the code comments. — kgautron
– kgautron, Commented Aug 1, 2012 at 8:47

Marko Topolnik · Accepted Answer · 2012-08-01 10:16:56Z

1

The assignment

Collection<T> myCol = null;
myCol = child.createList();

will fail because you are assigning Collection<ClassChild1> to a Collection parameterized with an unknown type T, which may or may not be ClassChild1.

You have specified T as inferred at the call site, so imagine the following code:

Class1 c1;
Collection<ClassChild2> c = c1.doSth();

You can see that the compiler would paint itself into a corner if it allowed you to compile such a doSth method since inside that method you want to add a ClassChild1 instance to a collection that in this example happens to hold instances of ClassChild2.

edited Aug 1, 2012 at 10:16

answered Aug 1, 2012 at 8:45

Marko Topolnik

201k31 gold badges336 silver badges455 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Jayant Varshney · Accepted Answer · 2012-08-01 08:54:15Z

0

Collection<ClassChild1> col = getCollectionFromSomewhere();
return col;

is returning a collection but actually your ClassChild1 is not a collection. This will definitely create compile time error. Make sure that the return type of the method must be a collection type or its descendant

answered Aug 1, 2012 at 8:54

Jayant Varshney

1,8351 gold badge28 silver badges42 bronze badges

Comments

prockel · Accepted Answer · 2012-08-01 09:08:24Z

0

createList does not provide a Collection, this is also an error.

You cannot assign a list of ClassChild1 to a list of T.

For example, if you rename RootClass to Animal, ClassChild1 to Cat. If now one instance of T would not be a Cat, you clearly cannot do the assignment you want.

edited Aug 1, 2012 at 9:08

answered Aug 1, 2012 at 9:03

prockel

2531 gold badge2 silver badges10 bronze badges

Comments

Daniel Earwicker · Accepted Answer · 2012-08-01 09:19:31Z

It's hard to tell what the problem is, because:

public ClassChild1 createList(){

Must be wrong (as others have noted). Does it actually say:

public Collection<ClassChild1> createList(){

This compiles okay:

import java.util.*;

interface ClassRoot {}

class ClassChild1 implements ClassRoot {

    public Collection<? extends ClassRoot> createList(){

        Collection<ClassChild1> col = new ArrayList<ClassChild1>();
        return col;
    }
}

class Class1{
    protected Collection<? extends ClassRoot> doSth(){
        Collection<? extends ClassRoot> myCol = null;
        ClassChild1 child = new ClassChild1();

        myCol = child.createList();
        return myCol;
    }
}

I've declared createList to return something that is assignable to ClassRoot. What it returns is compatible with that.

Then I've changed doSth to return the same thing, so it is also compatible.

The downside is that you still cannot call:

myCol.add(child);

And for a good reason - even though we don't know what restriction exists on the collection items, that doesn't mean that there is no restriction (the room doesn't disappear when you turn the light off).

sakthisundar · Accepted Answer · 2012-08-01 09:36:08Z

factored your code here . Your ClassChild implementation is,

public class ClassChild implements ClassRoot {
    public List<ClassChild> createList() {
        return Arrays.asList(new ClassChild[] {new ClassChild(), new ClassChild()});
    }


}

and your Class1 is

public class Class1 {

    public static <T extends ClassRoot> Collection<T> doSth(){
        Collection<T> myCol = null;
        ClassChild child = new ClassChild();
        /*you should note here*/
        myCol =  (Collection<T>) child.createList();
        return  myCol;
    }
}

You have to stop and at the place where I have mentioned as "You have to note here". If you do a cast as Collection , the problem is solved. But coming to your question, you have created a collection named myCol which contains type T that extends ClassRoot. But what is the guarantee that createList will return a collection that contains subtypes ClassRoot ? So you always to have cast explicitly.

Collectives™ on Stack Overflow

Java Generics & Polymorphism

5 Answers 5

Comments

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

Comments

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related