Wrong execution on function in JS

Question

I have this code, but somewhy when i use this function to validate my input field everything works, except + and - keys, even thought i noted them as true. What have i done wrong?

function validateNumber(event)
{
    var key = window.event ? event.keyCode : event.which;

    if (event.keyCode == 8 || event.keyCode == 46 || event.keyCode == 37 ||
        event.keyCode == 39 || event.keyCode == 107 || event.keyCode == 109 ||
        event.keyCode == 32 )
    {
        return true;
    }
    else if(key < 48 || key > 57)
    {
        return false;
    }
    else return true;
};

i took code from that question, but did some changes, and now it doesnt works as intend — Avdept
– Avdept, Commented Aug 3, 2012 at 8:27

katspaugh · Accepted Answer · 2012-08-03 09:59:32Z

2

I don't see you checking for 189 (-) and 187 (=, which is really what happens when you type +). You might want to check if the Shift key is pressed for +.

As already noted, it's overall a wrong way to validate user input. You need to inspect the value of the input, not individual keystrokes.

First, define a validation function that would check an arbitrary text with a regexp:

function checkArithmetic(str) {
    var regexp = /^[0-9+-]$/;
    return regexp.test(str);
}

Next, add a handler to your input element:

input.addEventListener('input', function (e) {
    var value = input.value;

    if (checkArithmetic(value)) {
        // OK!
    } else {
        // error
    }
}, false);

edited Aug 3, 2012 at 9:59

answered Aug 3, 2012 at 8:27

katspaugh

18k12 gold badges69 silver badges107 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Avdept Over a year ago

the problem is that i dont have access to form by itself, i can only use some js, to do any actions based on id

Collectives™ on Stack Overflow

Wrong execution on function in JS

1 Answer 1

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related