rails, syntax error, unexpected ','

Question

I have several conditions in my search.

@events = Event.search(params[:search], 
  :conditions => {:group_size => 1, :days => 1})

The above code is working fine. However, if I want to replace the hash with a private method, I get syntax error

syntax error, unexpected ',', expecting tASSOC
    :conditions => {group_size_condition, :days => 1},

Code is as follow

@events = Event.search(params[:search], 
  :conditions => {group_size_condition, :days => 1})

private

def group_size_condition
  if params[:groupsize] == 'single (1)'
    :group_size => 1
  elsif params[:groupsize] == 'couple (2)'
    :group_size => 2
  elsif params[:groupsize] == 'small group(3-5)'
    :group_size => 3..5
  else
    nil
  end
end

Thanks in advance

jalkoby · Accepted Answer · 2012-08-12 19:43:38Z

2

That will be work

@events = Event.search(params[:search], 
  :conditions => group_size_condition.merge(:days => 1))

private

def group_size_condition
  case params[:groupsize]
  when 'single (1)' then {:group_size => 1}
  when 'couple (2)' then {:group_size => 2}
  when 'small group(3-5)' then {:group_size => 3..5}
  else
    {}
  end
end

answered Aug 12, 2012 at 19:43

jalkoby

3791 silver badge4 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Pawel · Accepted Answer · 2012-08-12 19:11:34Z

0

I think you missed :group_size key

@events = Event.search(params[:search], 
  :conditions => {:group_size => group_size_condition, :days => 1})

answered Aug 12, 2012 at 19:11

Pawel

9446 silver badges11 bronze badges

2 Comments

user1495133 Over a year ago

I think I also need to change the private method. It should only return the value, instead of the entire condition.

user1495133 Over a year ago

an irrelevant question, @pkubicki. basically I want to ignore the groupsize search condition if groupsize fall into 'else' condition. It looks like nil is not correct in this case. Do you know how to achieve this goal?

Michael Durrant · Accepted Answer · 2012-08-12 19:15:39Z

0

I think perhaps you want to actually pass the string, as in:

def group_size_condition
  if params[:groupsize] == 'single (1)'
    ':group_size => 1'
  elsif params[:groupsize] == 'couple (2)'
    ':group_size => 2'
  elsif params[:groupsize] == 'small group(3-5)'
    ':group_size => 3..5'
  else
    nil
  end
end

answered Aug 12, 2012 at 19:15

Michael Durrant

97.1k102 gold badges352 silver badges536 bronze badges

1 Comment

user1495133 Over a year ago

thanks for the quick turnaround. But the above code does not work. Still get the same error.

Collectives™ on Stack Overflow

rails, syntax error, unexpected ','

3 Answers 3

Comments

2 Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

2 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related