If/Else statement in onclick functions

Question

I have this onclick function and it is working fine:

onclick="transferplayer('palyerlistDIVID','<?=$d_player['id']?>',document.getElementById('play perPosition').value,'teamID','plus','<?=$d_player['teamID']?>','<?=$d_player['price']?>');showmyplayer('myplayerlistDIVID',document.getElementById('playperPosition').value,'plus','<?=$d_player['teamID']?>','<?=$d_player['price']?>')"

What I need is to set a time between clicks, so I added this javascript with 5 seconds between each click:

var lastClicked = 0;

function onClickCheck() {
    var timeNow = (new Date()).getTime();
    if (timeNow > (lastClicked + 5000)) {
        // Execute the link action 
    } else {
        alert('Please wait at least 5 seconds between clicks!');
    }
    lastClicked = timeNow;
}

The question is: how can I combine this code with onclick functions?

I tried this:

onclick="onClickCheck();transferplayer('palyerlistDIVID','<?=$d_player['id']?>',document.getElementById('play perPosition').value,'teamID','plus','<?=$d_player['teamID']?>','<?=$d_player['price']?>');showmyplayer('myplayerlistDIVID',document.getElementById('playperPosition').value,'plus','<?=$d_player['teamID']?>','<?=$d_player['price']?>')"

But on clicking it takes the values always.

Mihai Iorga · Accepted Answer · 2012-09-08 07:56:41Z

2

It is not advisable to use inline javascript. You should try to bind the click on that element.

But your answer:

onclick="var lastClicked = 0;if(timeNow>(lastClicked + 5000)){ var timeNow = (new Date()).getTime(); if (timeNow > (lastClicked + 5000)) { transferplayer('palyerlistDIVID','<?=$d_player['id']?>',document.getElementById('play perPosition').value,'teamID','plus','<?=$d_player['teamID']?>','<?=$d_player['price']?>');showmyplayer('myplayerlistDIVID',document.getElementById('playperPosition').value,'plus','<?=$d_player['teamID']?>','<?=$d_player['price']?>'); }else{ alert('Please wait at least 5 seconds between clicks!'); } lastClicked = timeNow;"

answered Sep 8, 2012 at 7:56

Mihai Iorga

39.8k17 gold badges109 silver badges109 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

11684 Over a year ago

Why not move this all into a function?

Community · Accepted Answer · 2017-05-23 12:03:18Z

2

Just move the transferplayer call into your if clause.

onclick="onClickCheck()"


function onClickCheck() {
    var timeNow = (new Date()).getTime();
    if (timeNow > (lastClicked + 5000)) {
        transferplayer('palyerlistDIVID','<?=$d_player['id']?>',
                        document.getElementById('playerPosition').value,
                        'teamID',
                        'plus',
                        '<?=$d_player['teamID']?>',
                        '<?=$d_player['price']?>');

         showmyplayer('myplayerlistDIVID',
                      document.getElementById('playperPosition').value, 
                      'plus',
                      '<?=$d_player['teamID']?>',
                      '<?=$d_player['price']?>');
    } else {
        alert('Please wait at least 5 seconds between clicks!');
    }
    lastClicked = timeNow;
}

And, for the record, use of PHP short tags is not recommended. See PHP echo vs PHP short tags for a discussion of the subject.

edited May 23, 2017 at 12:03

CommunityBot

11 silver badge

answered Sep 8, 2012 at 7:56

sberry

133k20 gold badges145 silver badges171 bronze badges

1 Comment

Glavić Over a year ago

About the short tags... I agree when <? is used, but <?= is completly ok, even php 5.4. advices the use > docs.php.net/manual/en/migration54.new-features.php (<?= is now always available, regardless of the short_open_tag php.ini option.)

Collectives™ on Stack Overflow

If/Else statement in onclick functions

2 Answers 2

1 Comment

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related