C++ why does my array not pop into my stack?

Question

I created an array for studentrecords and am supposed to pop it into my stack.. well everything works except for my stack.pops and stack.pushes in MAIN...I am so close to finishing this program I am wondering if anyone knows any solutions?

#include <iostream>
#include <list>
#include <cstdlib>
#include <cstring>
#include <iomanip>
#include <string>

using namespace std;

class Studentrecords
{
private:
    struct student
    {
        string name;
        string address;
        int ID;
        double gpa;
    };

    student *stackArray;
    int stackSize;
    int top;

public:
    Studentrecords();
    Studentrecords(int size);
    ~Studentrecords();
    void push(string name, string address, int id, double gpa);
    void pop();
    bool isFull() const;
    bool isEmpty() const;
    void display();
};

Studentrecords::Studentrecords(int size)
{
    stackArray = new student[size];
    top = -1;
}

Studentrecords::Studentrecords()
{
    stackSize = 20;
    stackArray = new student[stackSize];
    top = -1;
}

Studentrecords::~Studentrecords()
{
    delete [] stackArray;
}

void Studentrecords::push (string name, string address, int id, double gpa)
{
    if (isFull())
    {
        cout << "The stack is full!" << endl;
    }
    else
    {
        student newStudent;
        newStudent.name = name;
        newStudent.address= address;
        newStudent.ID = id;
        newStudent.gpa = gpa;
        stackArray[top] = newStudent;
        top++;
    }
}

void Studentrecords::pop ()
{
    if (isEmpty())
    {
        cout << "The stack is empty!" << endl;
    }
    else
    {
        cout << stackArray[top-1].name << endl;
        cout << stackArray[top-1].address << endl;
        cout << stackArray[top-1].ID << endl;
        cout << stackArray[top-1].gpa << endl;
        top--;
    }
}

bool Studentrecords::isFull() const
{
    bool status;
    if (top == stackSize - 1)
        status = true;
    else
        status = false;
    return status;
}

bool Studentrecords::isEmpty() const
{
    bool status;
    if (top == -1)
        status = true;
    else
        status = false;
    return status;
}

void Studentrecords::display()
{
    for (int i = 0; i< top; i++)
    {
        cout << stackArray[i].name << endl;
        cout << stackArray[i].address << endl;
        cout << stackArray[i].ID << endl;
        cout << stackArray[i].gpa << endl << endl;
    }
}

int main()
{
    int catchVar;

    Studentrecords stack();

    cout << "Pushing 1st";
    stack.push("Jonny", "123 ave", 2343, 3.2);

    cout << "pushing 2nd";
    stack.push("Robby", "123 ave", 2343, 3.2);

    cout << "Popping ";
    stack.pop(catchVar);
    cout << catchVar << endl;

    cout << "Popping ";
    stack.pop(catchVar);
    cout << catchVar << endl;

    return 0;
}

Does this code even compile? You're calling pop(catchVar) but pop() takes no parameters. — Greg Hewgill
– Greg Hewgill, Commented Sep 20, 2012 at 23:09
you might want to work on your indention and reduce the code to the relevant parts. You might also want to mention what exactly the problems are. It's not really fun to wade through less then desiarable indented code without knowing what one is looking for... — Grizzly
– Grizzly, Commented Sep 20, 2012 at 23:11
You kind of forgot to tell us what the problem is. Just telling us that something doesn't work isn't very helpful. Think about it like going to a mechanic -- would you just say "my car doesn't work"? Or would you tell him what precisely you were doing and what precisely went wrong? — David Schwartz
– David Schwartz, Commented Sep 20, 2012 at 23:20

Seth Carnegie · Accepted Answer · 2012-09-20 23:08:09Z

6

Studentrecords stack();

Does not declare a Studentrecords named stack, it declares a function named stack that returns a Studentrecords. Change it to

Studentrecords stack;

Also your class needs at least a copy constructor and assignment operator.

answered Sep 20, 2012 at 23:08

Seth Carnegie

75.3k22 gold badges185 silver badges252 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

Lily Ballard Over a year ago

Incidentally, clang++ provides a very clear warning for this most vexing parse. It's a shame GCC doesn't.

Praetorian Over a year ago

Or Studentrecords stack{}; if you have a C++11 compiler

Seth Carnegie Over a year ago

@Prætorian that's unnecessary though, so best to just leave them off.

Praetorian Over a year ago

In this case, it is. But what if Studentrecords was a POD?

Seth Carnegie Over a year ago

@KevinBallard unfortunately most people learning C++ do so at a university on a very old compiler or using Windows at home, they don't have a chance to use clang.

efaj · Accepted Answer · 2012-09-20 23:11:23Z

0

Can you post the compiler's error? Or the produced output VS the expected output? Without that, I'll have to say that your pop function doesn't take arguments and you are passing it catchVar... that would be a compiler error.

answered Sep 20, 2012 at 23:11

efaj

9431 gold badge12 silver badges24 bronze badges

Collectives™ on Stack Overflow

C++ why does my array not pop into my stack?

2 Answers 2

5 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

5 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related