Bash script to change config using sed

Question

I'm trying to change the value of malloc to say 1234m via a bash script but not seeing any changes. I presume it is an issue with my regex, can anybody see what I've done inncorrectly?

String

DAEMON_OPTS="-a :6081 \
             -T localhost:6082 \
             -f /etc/varnish/default.vcl \
             -S /etc/varnish/secret \
             -s malloc,256m"

Code

# get the memory allocation
echo "Enter the memory allocation"
read malloc

# update the default config
sed -ie 's/malloc,.*[0-9m]$/malloc,'$malloc'/gI' /etc/default/varnish

choroba · Accepted Answer · 2012-10-12 09:41:54Z

3

You are missing a " before the $ in the sed pattern.

By the way, your pattern works, but in a different way than you probably intended: the character class [0-9m] matches just one character, m in this case. The number is being matched by .*. Better pattern might be malloc,[0-9]\+m"$.

answered Oct 12, 2012 at 9:41

choroba

245k27 gold badges221 silver badges304 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

gazzwi86 Over a year ago

This worked brilliantly, thanks! Can't believe I missed the m" at the end of the line!

anubhava · Accepted Answer · 2012-10-12 09:46:06Z

1

Try this sed command:

On Mac:

sed -E 's/malloc,[0-9]+m/malloc,'$malloc'/' /etc/default/varnish

or on Linux:

sed -r 's/malloc,[0-9]+m/malloc,'$malloc'/' /etc/default/varnish

answered Oct 12, 2012 at 9:46

anubhava

790k67 gold badges603 silver badges671 bronze badges

Comments

imp25 · Accepted Answer · 2012-10-12 09:53:31Z

0

The following sed line worked for me, enclosing it in " rather than ':

 sed -ie "s/malloc,[0-9]\+m$/malloc,$malloc/gI" /etc/default/varnish

answered Oct 12, 2012 at 9:53

imp25

2,35716 silver badges23 bronze badges

Collectives™ on Stack Overflow

Bash script to change config using sed

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related