Provide string as dynamic function with inline changes

Question

This currently works:

    $get_pending_list_action = "get_pending_list_".$action;
    $data = $this->sectorswaps->{$get_pending_list_action}($list);

Is there anyway to make it so I can turn this into one line?

i.e. this does NOT work:

    $data = $this->sectorswaps->get_pending_list_{$action}($list);

Is there some other way that I dont know of?

did you try: $data = $this->sectorswaps->{"get_pending_list_".$action}($list); — Matt Whipple
– Matt Whipple, Commented Oct 14, 2012 at 14:40
@MattWhipple - thanks matt - its so obvious now. if you can post that as the answer - i'll accept — Laurence
– Laurence, Commented Oct 14, 2012 at 14:43
@MarkBaker: There is nothing wrong about learning new things.. — raidenace
– raidenace, Commented Oct 14, 2012 at 14:43
A one-liner might be easier for you to read when it's fresh in your mind, and you know what you're expecting.... doesn't necessarily make it easier for others to read and understand, or for you to remember it in 6 months time. There's nothing wrong with learning new things, but new isn't always better... more important to learn the how to code in a way that you and others can subsequently maintain with ease... if a one-liner is "better", then use it; but knowing when to use more than one line for readability is also a coding skill. — Mark Baker
– Mark Baker, Commented Oct 14, 2012 at 14:48

Matt Whipple · Accepted Answer · 2012-10-14 14:44:27Z

2

$data = $this->sectorswaps->{"get_pending_list_".$action}($list);

answered Oct 14, 2012 at 14:44

Matt Whipple

7,1541 gold badge26 silver badges35 bronze badges

Sign up to request clarification or add additional context in comments.

1 Answer 1