php error - loop running one time extra?

Question

I have written php script to read the content from text file and insert them into database. The text file have has just 3 entries but while loop is running 4 times. Don't know why??

Here, is the script

$con = mysql_connect("localhost","root","root") or die("Could not connect to server");
$db = mysql_select_db("bolly_songs",$con) or die("Could not select database");

$file1 = "ex_name.txt";
$file2 = "ex_link.txt";

$fp1 = fopen($file1,"r");
$fp2 = fopen($file2,"r");

$ctr =1 ;

while(!feof($fp1)){
    $text1 = fgets($fp1);
    $text2 = fgets($fp2);

    $id = "emov".$ctr;

    $query = "insert into example_table(movie_name, movie_link,movie_id) values('$text1', '$text2','$id')";

    $result = mysql_query($query) or die("Query failed ".mysql_error());

    echo "Data inserted in field $ctr with id as $id \n";
    $ctr++;
}

fclose($fp1);
fclose($fp2);

As the script is running one time extra, it inserts a row in table with just $id value and rest both fields empty. Thanks!!

What happens when you initialize your counter to 0 instead of 1? — davepmiller
– davepmiller, Commented Oct 19, 2012 at 22:39

Rawkode · Accepted Answer · 2012-10-19 22:40:08Z

1

fgets returns false if there's nothing to read, so check for it returning (===) false within your loop, or change your loop to this example from the documentation:

while (($buffer = fgets($handle, 4096)) !== false) {
    if (!feof($handle)) {
        echo "Error: unexpected fgets() fail\n";
    }
    fclose($handle);
}

answered Oct 19, 2012 at 22:40

Rawkode

22.7k5 gold badges42 silver badges46 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

php error - loop running one time extra?

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related