VBscript Unable to Run Shell Command

Question

I have set up the following Sub to run shell commands quickly and easily. This script works for the login scripts at my company without fail. I am currently developing a script to add a large batch of users to our domain. When I used this Sub in my new script I receive an error saying that the file cannot be found. I have tried using the fix in this stackoverflow post, but I recieve the same error even with this code. VBScript WScript.Shell Run() - The system cannot find the file specified

The part I find puzzling is that this sub works just fine when run from the netlogon folder of our domain controller. What am I doing wrong?

Thanks,

Sub runcommand(strCommand)
Dim objWshShell, intRC
set objWshShell = WScript.CreateObject("WScript.Shell")
intRC = objWshShell.Run(strCommand, 0, TRUE)
call reportError(intRC,strCommand)
set objWshShell = nothing 
end Sub

function reportError(intRC, command)
if intRC <> 0 then 
 WScript.Echo "Error Code: " & intRC 
 WScript.Echo "Command: " & command 
end if
end function

Since you didn't specify... trying to run the value of strCommand in the command prompt succeeds, right? — Daniel
– Daniel, Commented Oct 25, 2012 at 14:45
Yes running this from the command line does not return any errors — Talon06
– Talon06, Commented Oct 25, 2012 at 15:05
It varies depending on what is needed, but so far in testing I was trying to just echo out variables. Currently the value of strCommand is "echo Hello World" — Talon06
– Talon06, Commented Oct 25, 2012 at 15:51
Well that's not an executable program, to run that you need to pass it to the command interpreter objWshShell.Run("cmd /k echo Hello World", 1, TRUE) — Alex K.
– Alex K., Commented Oct 25, 2012 at 16:22

Lizz · Accepted Answer · 2012-10-26 07:18:10Z

1

The previous values for strCommand had no spaces and were very straightforward. Your new script is passing more complex variables to your Sub so you need additional conditional handling, as Alex K. pointed out in his Collusion (i.e., "Comment/Solution") above. Alex K.'s sample above is perfect, so, being a Point Pimp tonight, will post it as the solution:

objWshShell.Run("cmd /k echo Hello World", 1, TRUE)

answered Oct 26, 2012 at 7:18

Lizz

1,4685 gold badges25 silver badges52 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

VBscript Unable to Run Shell Command

1 Answer 1

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related