Javascript Ternary Operator in Sequence

Question

I got the code below from a Javascript Library:

function func_1()
{
    if ( null == decimal ) 
    {
        return dPR || (dpr(2) ? 2 : dpr(1.5) ? 1.5 : dpr(1) ? 1 : 0);
    }
}

I'm particularly interested in the code inside the if statement.

How else can I write this so that it's easier to read?! As it is now I can't understand it.

Thanks.

Give meaningful names to the constants and don't use some random acronyms. — Esailija
– Esailija, Commented Nov 14, 2012 at 23:50
Post all your code. I believe it is missing some definitions. — Fred Wuerges
– Fred Wuerges, Commented Nov 14, 2012 at 23:51

Michał Miszczyszyn · Accepted Answer · 2012-11-14 23:51:11Z

4

it's equivalent to:

if (dPR) {
    return dPR;
} else {
    if (dpr(2)) {
        return 2;
    } else {
        if (dpr(1.5)) {
            return 1.5;
        } else {
            if (dpr(1)) {
                return 1;
            } else {
                return 0;
            }
        }
    }
}

answered Nov 14, 2012 at 23:51

Michał Miszczyszyn

12.8k2 gold badges38 silver badges53 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

David Müller · Accepted Answer · 2012-11-14 23:52:46Z

1

if (dPr) {
    return dPr;
} 
else {
    if (dpr(2))
        return 2
    else if (dpr(1.5))
        return 1.5;
    else if (dpr(1))
        return 1;
    else 
        return 0;
}

answered Nov 14, 2012 at 23:52

David Müller

5,3612 gold badges32 silver badges34 bronze badges

1 Comment

ObiHill Over a year ago

Thanks David. This is actually closer to what my brain wants to process as regards the question.

David G · Accepted Answer · 2012-11-15 00:14:37Z

0

if ( decimal == null ) {

    if ( dPR ) {

        return dPR;

    } else {

        if ( dpr(2) ) {

            return 2;

        } else if ( dpr(1.5) ) {

            return 1.5;

        } else if ( dpr(1) ) {

            return 1;

        } else return 0;

    }

}

edited Nov 15, 2012 at 0:14

answered Nov 14, 2012 at 23:50

David G

97.6k41 gold badges173 silver badges258 bronze badges

1 Comment

David Müller Over a year ago

This is not correct, you do have a double else-branch in your code.

Collectives™ on Stack Overflow

Javascript Ternary Operator in Sequence

3 Answers 3

Comments

1 Comment

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

1 Comment

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related