creating file type condition when uploading files in php

Question

I am using this condition, but it's not working as it is always false i.e no file types meet the condition, so i fighre there must be an error in syntax but I can't figure it out.

if (!($_FILES["uploaded"]["type"] == "video/mp4")
&& (!$_FILES["uploaded"]["type"] == "video/flv")
&& (!$_FILES["uploaded"]["type"] == "video/webm" )
&& (!$_FILES["uploaded"]["type"] == "video/ogg" ))

{
   $message="not an accepted file format";
}

hakre · Accepted Answer · 2012-12-20 01:38:34Z

5

A common case for in_array:

$type          = $_FILES["uploaded"]["type"];
$allowedTypes  = ["video/mp4", "video/flv", "video/webm", "video/ogg"];
$isRefusedType = !in_array($type, $allowedTypes);
if ($isRefusedType) {
    $message = "not an accepted file format";
}

Or isset against a flipped array:

$type          = $_FILES["uploaded"]["type"];
$allowedTypes  = array_flip(["video/mp4", "video/flv", "video/webm", "video/ogg"]);
$isRefusedType = !isset($allowedTypes[$type]);
if ($isRefusedType) {
    $message = "not an accepted file format";
}

edited Dec 20, 2012 at 1:38

answered Dec 20, 2012 at 1:31

hakre

200k55 gold badges454 silver badges865 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

jeroen Over a year ago

Yep, I'd definitely go for in_array myself.

Dan Lugg Over a year ago

Anything not to use a switch, eh? ;) The value here, is that the disallowed types can be loaded from configuration.

hakre Over a year ago

Yes both are pretty similar in this case. I first tended to write an in_array example but found array keys worth to show, too. in_array examples exist, but can't find it yet. - Okay, added and also seeing it was the wrong logic, not refused types, but allowed ones.

jeroen · Accepted Answer · 2012-12-20 01:27:30Z

5

if ( !($_FILES["uploaded"]["type"] == "video/mp4"
       || $_FILES["uploaded"]["type"] == "video/flv"
       || $_FILES["uploaded"]["type"] == "video/webm"
       || $_FILES["uploaded"]["type"] == "video/ogg") )
{
   $message="not an accepted file format";
}

I assume valid means any of these types, so you check for any of these (using or) and than negate it.

edited Dec 20, 2012 at 1:27

answered Dec 20, 2012 at 1:21

jeroen

91.8k22 gold badges117 silver badges132 bronze badges

7 Comments

ROY Finley Over a year ago

was typing this up when you posted +1

cheesemacfly Over a year ago

Shouldn't the ! character be outside the parentheses?

user1559811 Over a year ago

no because then if it's not mp4 but it is flv then the message will come up

jeroen Over a year ago

@user1559811 I misread your parentheses and forgot to remove the !'s, please check the updated answer.

cheesemacfly Over a year ago

@jeroen looks better without the parentheses!

|

Dan Lugg · Accepted Answer · 2012-12-20 01:31:04Z

2

Longer on a vertical scale, but in my opinion more readable.

switch ($_FILES["uploaded"]["type"]) {
    case "video/webm":
    case "video/mp4":
    case "video/flv":
    case "video/ogg":
        $message = "Okie dokie";
        break;
    default:
        $message = "Invalid format";
}

answered Dec 20, 2012 at 1:31

Dan Lugg

20.7k19 gold badges116 silver badges180 bronze badges

Collectives™ on Stack Overflow

creating file type condition when uploading files in php

3 Answers 3

3 Comments

7 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

3 Comments

7 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related