Entity Framework - System.StackOverflowException

Question

I am new to entity framework and have hit an issue trying to insert new items into a lookup table.

The error is -

"An unhandled exception of type System.StackOverflowException occurred in mscorlib.dll"

It is thrown in the final code block below where public DIEMEntities() is called.

It occurs whenever I add a new item, I can update items ok.

Any help would be appreciated.

The code is -

protected void OnSave(object sender, EventArgs e)
    {
        ArrayList validationErrors = new ArrayList();
        ContactTypeEO contactType = new ContactTypeEO();

        if (uxID.Value.Length > 0)
        {
            //Updating
            contactType.Id = int.Parse(uxID.Value);
        }

        contactType.Name = uxName.Text;
        contactType.ExpressionValidator = uxExpression.Text;

        contactType.Save(ref validationErrors);

        if (validationErrors.Count > 0)
        {
            ShowValidationMessages(validationErrors);
        }
        else
        {
            this.RefreshUI();
        }
    } 

public bool Save(ref ArrayList validationErrors)
    {
        ValidateSave(ref validationErrors);

        if (validationErrors.Count == 0)
        {
            if (Id == 0)
            {
                ContactTypeData.Insert(Name, ExpressionValidator);
            }
            else
            {
                ContactTypeData.Update(Id, Name, ExpressionValidator);
            }
            return true;
        }
        else
        {
            return false;
        }
    } 

/// <summary>
    /// Inserts the new Contact Type.
    /// </summary>
    /// <param name="name">The name.</param>
    /// <param name="validator">The validator.</param>
    public static void Insert(string name, string validator)
    {
        using (DIEMEntities diemEntities = new DIEMEntities())
        {
            Insert(name, validator);
        }
    }

    /// <summary>
    /// Inserts the new Contact Type.
    /// </summary>
    /// <param name="diemEntities">The DIEM Entities.</param>
    /// <param name="name">The name.</param>
    /// <param name="validator">The validator.</param>
    public static void Insert(DIEMEntities diemEntities, string name, string validator)
    {
        diemEntities.usp_ContactTypes_Insert(name, validator);
    } 

public partial class DIEMEntities : DbContext
{
    public DIEMEntities()
        : base("name=DIEMEntities")
    {
    }

... OTHER CODE}

It is thrown in the final code block below where public DIEMEntities() is called. and you chose to provide all the code except that one? That doesn't even make sense. We have everything except the method that's failing. — Mike Perrenoud
– Mike Perrenoud, Commented Jan 4, 2013 at 13:06
Have you tried stepping through to see which line it fails at? — Gaz Winter
– Gaz Winter, Commented Jan 4, 2013 at 13:06

Paul Fleming · Accepted Answer · 2023-10-02 17:32:39Z

16

You have a recursive loop here:

public static void Insert(string name, string validator)
{
    using (DIEMEntities diemEntities = new DIEMEntities())
    {
        Insert(name, validator);
    }
}

This will execute continuously until you run out of memory.

I believe your intention is to do this:

public static void Insert(string name, string validator)
{
    using (DIEMEntities diemEntities = new DIEMEntities())
    {
        Insert(diemEntities, name, validator);
    }
}

edited Oct 2, 2023 at 17:32

answered Jan 4, 2013 at 13:07

Paul Fleming

24.6k8 gold badges79 silver badges113 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Thameem Over a year ago

plus for the term recursive loop

Collectives™ on Stack Overflow

Entity Framework - System.StackOverflowException

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related