Variable not setting in nested for loop - Windows batch

Question

Below is a simplified snippet of my code:

@echo off    
setlocal enabledelayedexpansion
    for /f %%f in ('%pomFiles%') do (
        findstr "var" %%f > nul
        if errorlevel 0 if not errorlevel 1 (
            cd "%%~dpf"
            for /f "usebackq" %%i in ('%%~dpftree.out') do ( set size=%%~zi && echo !size!)
            if !size! gtr 0 (
                   //do  stuff
            )
        )
    )

The !size! variable does not seem to be being set. If I do echo !size!, it prints !size!. How can I make sure !size! evaluates?

possible duplicate of Batch file printing out commands with @echo off — Vicky
– Vicky, Commented Feb 4, 2013 at 15:09
better to edit your original question as you home in on the problem, rather than post a whole new question. — Vicky
– Vicky, Commented Feb 4, 2013 at 15:09
@Vicky, I have fixed the issue of the commands printing due to your suggestion which I will mark as an answer if you post it. However I felt this was a completely different issue... — Alex
– Alex, Commented Feb 4, 2013 at 15:12

Bali C · Accepted Answer · 2013-02-04 14:59:03Z

1

It's because you are using for /f, which is to read the contents of a file, hence the problem is you are trying to get the size of the variable %%i, which is set as the first line in the file.

You just need a regular for loop

for %%i in ("%%~dpftree.out") do ( set size=%%~zi && echo !size!)
if !size! gtr 0 (
    //do  stuff
)

answered Feb 4, 2013 at 14:59

Bali C

31.4k37 gold badges128 silver badges155 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Alex Over a year ago

Thanks for the suggestion Bali C, but even with this code change it still seems to print out !size! rather than the value. If I write echo %%~zi the size does print...

Bali C Over a year ago

Hmm, you have enabled delayed expansion haven't you? I know it's in your example, but it sounds like you don't. I just tested it and it works fine for me?

Alex Over a year ago

Yes, it is the first line before the first for-loop as shown in my example. That should enable delayed expansion for the inner-loop as well right? Given your proposed new for statement, is it sufficient to put the if !size! gtr 0 in the body of the for loop and change !size! for %%~zi? This loop will only every run once, right?

Bali C Over a year ago

Yeah, as long as it's there it should work. In theory yes that should work fine, try that without assigning it to size first.

Collectives™ on Stack Overflow

Variable not setting in nested for loop - Windows batch

1 Answer 1

4 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

4 Comments

Your Answer

Sign up or log in

Post as a guest

Related