Updating data in database using datagridview

Question

i have a code like this:

public int updateFriend(long id, string Firstname, string Lastname, string Nickname, DateTime Birthdate, int Age, string Gender)
    {
        OleDbConnection con = new OleDbConnection(conString());

        string query = "UPDATE FriendList SET Firstname  ='" + Firstname + "', Lastname ='" + Lastname + "',Nickname ='" + Nickname + "',Birthday ='" + Birthdate + "',Age ='" + Age + "', Gender  ='" + Gender + "' WHERE ID = " + id;

        OleDbCommand cmd = new OleDbCommand(query, con);

        con.Open();

        int rowsAffected = cmd.ExecuteNonQuery();
        con.Close();

        return (rowsAffected);
    }

now the problem is when i click the update button it calls the method updateFriend, then an error appears on the Line "int rowsAffected = cmd.ExecuteNonQuery();" saying

"No value given for one or more required parameters."

Can somebody help me with this?

You should use Parameterized query also look up how to use Parameters.AddWithValue() Method also wrap that code in a Try{}catch{} refactor the Update statement to use Params also look at string.Format to format the Update statement try to avoid using Single Quotes mixed with Double Quotes.. you will only confuse yourself in the long run.. — MethodMan
– MethodMan, Commented Feb 11, 2013 at 14:38
Did you verify that all of the parameters getting passed to the query have values? — Ryan Byrne
– Ryan Byrne, Commented Feb 11, 2013 at 14:40
OleDbConnection con = new OleDbConnection(conString()); where is conString Declared..? — MethodMan
– MethodMan, Commented Feb 11, 2013 at 14:42

gzaxx · Accepted Answer · 2013-02-11 14:45:15Z

2

string query = "UPDATE FriendList SET Firstname  ='" + Firstname + "', Lastname ='" + Lastname + "',Nickname ='" + Nickname + "',Birthday ='" + Birthdate + "',Age ='" + Age + "', Gender  ='" + Gender + "' WHERE ID = " + id;

You are passing all parameters as string where some of them are int and one is DateTime. As suggested you should use Parameters.AddWithValue()

string query = "UPDATE FriendList SET Firstname = @Firstname, Lastname = @Lastname , Nickname = @Nickname, Birthday = @Birthdate, Age = @Age, Gender = @Gender WHERE ID = @id";
SqlCommand cmd = new SqlCommand(query, con);
cmd.Parameters.AddWithValue("@Firstname", FirstName);
//add rest parameters the same way as above
cmd.Parameters.AddWithValue("@id", id);

answered Feb 11, 2013 at 14:45

gzaxx

17.6k2 gold badges40 silver badges55 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Soner Gönül · Accepted Answer · 2013-02-11 15:03:57Z

1

Talking about on your error message;

"No value given for one or more required parameters."

This message will appears probably one of your parameters is null or zero-length string. Or the reason can be misspelling of your parameters.

Check your query in your database first and look which column gives you an error.

And please, never add your parameters in your sql command. That may cause SQL Injection attack. Always use parameterized query on your queries.

Check out SqlParameterCollection.AddWithValue() method from MSDN.

edited Feb 11, 2013 at 15:03

answered Feb 11, 2013 at 14:41

Soner Gönül

99.1k103 gold badges224 silver badges375 bronze badges

Collectives™ on Stack Overflow

Updating data in database using datagridview

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related