HTML Iframe get src with php

Question

I have an webpage where I want to have another html page displayed. I used iframes. The page gets to know what to load is via the get procedure. But there is an fault in this coding I think...

            <iframe src="
            <?
            $file       = ($_GET['ti'])

            if ($title = '')
                echo "information.html";
                else echo "$file";
            ?>
            "></iframe>

The url the page would recieve looks like this: http://www.website.com/reference.html?ti=unlimited.html

On a side note, depending on when you're setting your PHP variable you might be having a server/client side scripting issue, meaning you might need use some JavaScript (probably jQuery) to do a AJAX script to change the src attribute. — Iron3eagle
– Iron3eagle, Commented Feb 15, 2013 at 19:59

Iron3eagle · Accepted Answer · 2013-02-15 19:52:41Z

1

http://www.w3schools.com/php/php_if_else.asp

It's your if / else syntax and over all php code. It's not very well written.

<?php

$file = $_GET['ti'];

if ($title = '') {
     echo "information.html";
} else { 
     echo "$file";
}

?>

answered Feb 15, 2013 at 19:52

Iron3eagle

1,0777 silver badges24 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

UnholyRanger Over a year ago

Yes the code is not written well but the If/Else is not the 'issue'. You do not need brackets if one line follows. Yes it's a good practice, but not needed.

Iron3eagle Over a year ago

With out the braces the if will only execute the immidately after it ignoring the else statement. At least thats my understanding.

UnholyRanger Over a year ago

Yes the if statement will execute the next statement, but the else is still considered even without braces. Example

Iron3eagle Over a year ago

See what you're saying. Still makes my eyes hurt reading it :(

fedorqui · Accepted Answer · 2013-02-15 19:48:13Z

1

Need semicolon:

        $file       = ($_GET['ti']);

answered Feb 15, 2013 at 19:48

fedorqui

293k113 gold badges592 silver badges640 bronze badges

Comments

atmon3r · Accepted Answer · 2013-02-15 19:51:25Z

0

Use empty(), like this:

    <iframe src="
    <?
    $file       = ($_GET['ti'])

    if (empty($title))
        echo "information.html";
        else echo $file;
    ?>
    "></iframe>

answered Feb 15, 2013 at 19:51

atmon3r

1,9783 gold badges35 silver badges52 bronze badges

Comments

Green Black · Accepted Answer · 2013-02-15 19:52:36Z

0

<?php
    $possible = array("information.html", "home.html", "test.html");
    $file = isset($_GET['ti']) && 
            in_array($_GET['ti'], $possible)? $_GET['ti'] : "information.html";
?>
<iframe src="<?php echo $file;?>"></iframe>

answered Feb 15, 2013 at 19:52

Green Black

5,0571 gold badge19 silver badges29 bronze badges

Collectives™ on Stack Overflow

HTML Iframe get src with php

4 Answers 4

4 Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

4 Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related