Unable to call parametric-based jquery based function?

Question

I have a working jquery function which I can call like this through php

if (!order) 

        {   echo '<script>
$(function() {
$this = $("#ui-accordion-accordion-panel-0");
//  parent tab
var parent = $("#accordion").parent();
//parent.adderror();

// the content
$this.adderror();

// the header
var header = $this.attr("aria-labelledby");
$("#"+header).adderror();


// the tab
var tab = parent.attr("aria-labelledby");
$("#"+tab).parent().adderror();
});

    </script>';}

I want to make this a global function (even better if defined externally in a .js file) that I can call from wherever I want in my php, which takes the panel as a parameter.

So I would basically call - show_error("#ui-accordion-accordion-panel-0"). How could I do this? When I tried defining function, and then calling it - there was no change whatsoever. Was using through techinques defined here to no avail (var functionName = function() {} vs function functionName() {})

Thanks in advance

Ok, I have now an error.js file, which I have linked appropriately ( )

function show_error(selector) {
var $this = $(selector);

//  parent tab
var parent = $("#accordion").parent();

//parent.adderror();

// the content
$this.adderror();

// the header
var header = $this.attr("aria-labelledby");
$("#"+header).adderror();


// the tab
var tab = parent.attr("aria-labelledby");
$("#"+tab).parent().adderror();
}

FWIW, your function falls prey to The Horror of Implicit Globals because you don't declare your $this variable. — T.J. Crowder
– T.J. Crowder, Commented Feb 27, 2013 at 11:37
What's parent in the line var tab = parent.attr("aria-labelledby");? You haven't shown anything showing where you're getting that. — T.J. Crowder
– T.J. Crowder, Commented Feb 27, 2013 at 11:38
My bad, thought I would just post the snippet. Ended up confusing you all, I'm sorry. Just made the relevant edit now. — Pratik Bothra
– Pratik Bothra, Commented Feb 27, 2013 at 11:43

T.J. Crowder · Accepted Answer · 2013-02-27 11:45:25Z

1

The function in your external .js file would look like this:

function show_error(selector) {
    var $this = $(selector);
    //  parent tab
    var parent = $("#accordion").parent();
    //parent.adderror();

    // the content
    $this.adderror();

    // the header
    var header = $this.attr("aria-labelledby");
    $("#"+header).adderror();

    // the tab
    var tab = parent.attr("aria-labelledby");
    $("#"+tab).parent().adderror();
}

edited Feb 27, 2013 at 11:45

answered Feb 27, 2013 at 11:36

T.J. Crowder

1.1m201 gold badges2k silver badges2k bronze badges

Sign up to request clarification or add additional context in comments.

10 Comments

Pratik Bothra Over a year ago

I tried something very similar, didn't work. Will try again now.

T.J. Crowder Over a year ago

@PratikBothra: Well, again, there's the question of where you're getting parent. But fundamentally, that does work, barring other issues on your page not shown in your question.

Pratik Bothra Over a year ago

To help debug the code, I added an alert($this) in the function, and this is what I get - [object Object] as the alert. So the function is being called, but no change is happening at the moment. Pretty sure the alert message, shouldn't show that, or should it?

T.J. Crowder Over a year ago

@PratikBothra: It should, $this is a jQuery instance (object), since it's the return value of jQuery's $ function. That's why you can call methods on it.

Pratik Bothra Over a year ago

alert(selector) is giving me #ui-accordion-accordion-panel-0, if that helps

|

Collectives™ on Stack Overflow

Unable to call parametric-based jquery based function?

1 Answer 1

10 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

10 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related