Separate rows from a mysql database into differant variables

Question

I'm trying to separate a result into different arrays for each row, then output them into a table. Here is my code.. Its long I know and also outdated, but i just need it to work. Any help would be amazing. Currently it does echo the correct amount of rows, only they are all empty.

        <?php
        include ('user.inc');
        mysql_connect(localhost,$username,$password);
        @mysql_select_db($database) or die ("unable to select database");

            $query = 'SELECT * FROM customer LIMIT 50';
            $result=mysql_query($query);
            $num=mysql_numrows($result);

        mysql_close();

            $i=0;

            while ($i = mysql_fetch_array($result)){
                $customerID[$i]=$i['customerID'];
                $surname[$i]=$i['surname'];
                $forname[$i]=$i['forname'];
                $title[$i]=$i['title'];
                $email[$i]=$i['e-mail'];
                $adress[$i]=$i['address1'];
                $street[$i]=$i['street'];
                $city[$i]=$i['city'];
                $county[$i]=$i['cuunty'];
                $postcode[$i]=$i['postcode'];
                $phoneNumber[$i]=$i['phoneNumber'];
                $mobileNumber[$i]=$i['mobileNumber'];
            $i++;
            }
            $r=0;
            echo'<table>';
            while ($r < $num){
                echo'<tr>';
                echo'<td><form action="userinfo.php"><input type="hidden" name="customerID" value="';
                echo$customerID[$r];
                echo'"><imput type="submit" value="';
                echo$customerID[$r];
                echo'"></form></td>';
                echo'   <td>';
                echo$title[r];
                echo'</td>';
                echo'   <td>';
                echo$surname[r];
                echo'</td>';
                echo'   <td>';
                echo$forname[r];
                echo'</td>';
                echo'   <td>';
                echo$email[r];
                echo'</td>';
                echo'</tr>';
            $r++;
            }
            echo'</table>';
        ?>

You shouldn't be using the same variable for your counter as well as your associative array. — aqua
– aqua, Commented Mar 4, 2013 at 10:34

Yogesh Suthar · Accepted Answer · 2013-03-04 10:35:51Z

1

change this

$i=0;

        while ($i = mysql_fetch_array($result)){
            $customerID[$i]=$i['customerID'];
            $surname[$i]=$i['surname'];
            $forname[$i]=$i['forname'];
            $title[$i]=$i['title'];
            $email[$i]=$i['e-mail'];
            $adress[$i]=$i['address1'];
            $street[$i]=$i['street'];
            $city[$i]=$i['city'];
            $county[$i]=$i['cuunty'];
            $postcode[$i]=$i['postcode'];
            $phoneNumber[$i]=$i['phoneNumber'];
            $mobileNumber[$i]=$i['mobileNumber'];
        $i++;
        }

to

//$i=0;

        while ($i = mysql_fetch_array($result)){
            $customerID[]=$i['customerID'];
            $surname[]=$i['surname'];
            $forname[]=$i['forname'];
            $title[]=$i['title'];
            $email[]=$i['e-mail'];
            $adress[]=$i['address1'];
            $street[]=$i['street'];
            $city[]=$i['city'];
            $county[]=$i['cuunty'];
            $postcode[]=$i['postcode'];
            $phoneNumber[]=$i['phoneNumber'];
            $mobileNumber[]=$i['mobileNumber'];
        //$i++;
        }

answered Mar 4, 2013 at 10:35

Yogesh Suthar

30.5k18 gold badges75 silver badges100 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

user2131323 Over a year ago

didnt work sorry, i got a server error instead. Thanks anyway.

Yogesh Suthar Over a year ago

your code contains lots of error. first correct them, after that it will work.

user2131323 Over a year ago

Thanks very much, great help. id left a second '}' in the code which must have f'ed something up. Thanks again :D

karmafunk · Accepted Answer · 2013-03-04 10:56:20Z

0

Why are you reading all the data in to an array and then just writing it out? This is unnecessary and wastes memory. Put your echo statements into the first loop with references to the relevant array nodes.

answered Mar 4, 2013 at 10:56

karmafunk

1,45312 silver badges20 bronze badges

Collectives™ on Stack Overflow

Separate rows from a mysql database into differant variables

2 Answers 2

3 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related