update values of two Columns in SQL database using C#

Question

cmd.CommandText = "update  dbo.diagnosis SET id=" + SetValueForText + "ss=" + sh;

where sh and column ss are of bool datatype and id and SetValueForText are of int datatype. exception is invalid syntax near ss.

USE parametrized queries! to avoid SQL injection attacks and improve performance. ... — marc_s
– marc_s, Commented Mar 28, 2013 at 14:15

Justin Niessner · Accepted Answer · 2013-03-28 14:14:30Z

2

You're missing a comma between the first value and the second column name. You should also be using a parameterized query to protect against SQL Injection Attacks:

cmd.CommantText =
    "update dbo.diagnosis set id=@id, ss=@ss";

cmd.Parameters.Add("@id", SetValueForText);
cmd.Parameters.Add("@ss", sh);

Also keep in mind that you're not filtering any values so this update statement will update every row in the table.

answered Mar 28, 2013 at 14:14

Justin Niessner

246k40 gold badges416 silver badges546 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Sidra Abbasi Over a year ago

Justin please tell mee wherei have to put comma?

Collectives™ on Stack Overflow

update values of two Columns in SQL database using C#

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related