Rails nested list with concat content_tag in Helper

Question

I'm trying to create something similar to this: Using helpers in rails 3 to output html

Here's my helper:

def section_references_to_html (section)
     concat content_tag (:ol, :class => 'sources') do
        section.references.each do |reference|
          concat content_tag (:li,content_tag(:a, reference.text, :src => reference.url))
        end
      end
  end

But it's returning all sorts of syntax errors:

/~/app/helpers/application_helper.rb:21: syntax error, unexpected ',', expecting ')'
     concat content_tag (:ol, :class => 'sources') do
                             ^
/~/app/helpers/application_helper.rb:21: syntax error, unexpected ')', expecting keyword_end
     concat content_tag (:ol, :class => 'sources') do
                                                  ^
/~/app/helpers/application_helper.rb:22: syntax error, unexpected keyword_do_block, expecting keyword_end
        section.references.each do |reference|
                                  ^
/~/app/helpers/application_helper.rb:23: syntax error, unexpected tIDENTIFIER, expecting keyword_do or '{' or '('
          concat content_tag (:li,content_tag(:a, referen...
                            ^
/~/app/helpers/application_helper.rb:23: syntax error, unexpected ',', expecting ')'
...       concat content_tag (:li,content_tag(:a, reference.tex...
...                               ^
/~/app/helpers/application_helper.rb:23: syntax error, unexpected ')', expecting keyword_end

What am I doing wrong here? Maybe using partial would be better.

Mischa · Accepted Answer · 2013-04-01 13:22:58Z

3

The main problem is that you have spaces between content_tag and (. Try this:

def section_references_to_html(section)
  content_tag(:ol, class: 'sources') do
    section.references.each do |reference|
      content_tag(:li, content_tag(:a, reference.text, href: reference.url))
    end
  end
end

edited Apr 1, 2013 at 13:22

Mischa

43.4k9 gold badges101 silver badges111 bronze badges

answered Apr 1, 2013 at 12:42

Brian Petro

1,56716 silver badges32 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

Ryan King Over a year ago

This works, thanks. I thought you had to parse hashes to content_tag?

Brian Petro Over a year ago

It wasn't because of the hash notation. I fixed some spacing issues and just rewrote the code how I would. Happy to help.

Ryan King Over a year ago

oh I didn't know you could write it like that.

Ryan King Over a year ago

I does still need the spacing removed from in between the content_tag & the brackets - as well as src changed to href besides that works a treat. Thanks

NoDisplayName Over a year ago

I had the same problem and your example helped me but it didnt work untill I added "concat" before the content_tag with a "li" element

Collectives™ on Stack Overflow

Rails nested list with concat content_tag in Helper

1 Answer 1

5 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

5 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related