Functions in Visual Basic

Question

I'm supposed to make a score calculator for a Programming assignment, for a football game. it has 4 textboxes and a button, the function NEEDS to be there for full credit, I'm just not sure what I'm doing wrong.

Public Class Form1
Dim intTotal = 0
Dim intFirst = 0
Dim intSecond = 0
Dim intThird = 0
Dim intFourth = 0
Private Sub btnCalculate_Click(sender As Object, e As EventArgs) Handles btnCalculate.Click
    Try
        Dim intFirst As Integer = Convert.ToInt32(txtFirst.Text)
        Dim intSecond As Integer = Convert.ToInt32(txtSecond.Text)
        Dim intThird As Integer = Convert.ToInt32(txtThird.Text)
        Dim intFourth As Integer = Convert.ToInt32(txtFourth.Text)
    Catch ex As Exception
        MessageBox.Show("Enter in Digits!")
    End Try
    intTotal = calcTotal(intFirst, intSecond, intThird, intFourth, intTotal)
    Me.lblTotal.Text = intTotal 'Shows as 0 at run-time
End Sub
Function calcTotal(ByVal intFirst As Integer, ByVal intSecond As Integer, ByVal intThird As Integer, ByVal intFourth As Integer, ByVal intTotal As Integer) As Integer
    intTotal = intFirst + intSecond + intThird + intFourth
    Return intTotal
End Function
End Class

lblTotal ends up displaying 0.

What's wrong with it?

Rowland Shaw
– Rowland Shaw

2013-04-18 20:58:28 +00:00
Commented Apr 18, 2013 at 20:58 — Rowland Shaw
– Rowland Shaw, Commented Apr 18, 2013 at 20:58
lblTotal ends up displaying 0

user2275554
– user2275554

2013-04-18 20:59:16 +00:00
Commented Apr 18, 2013 at 20:59 — user2275554
– user2275554, Commented Apr 18, 2013 at 20:59

Kenneth · Accepted Answer · 2013-04-18 21:05:40Z

2

Your variables are declared at the block-level inside the try catch. Move the declarations out of the block and remove the class-level declarations (since they're not necesarry).

Like this:

Public Class Form1
    Private Sub btnCalculate_Click(sender As Object, e As EventArgs) Handles btnCalculate.Click

        Dim intFirst As Integer = 0
        Dim intSecond As Integer = 0
        Dim intThird As Integer = 0
        Dim intFourth As Integer = 0

        Try
           intFirst = Convert.ToInt32(txtFirst.Text)
            intSecond = Convert.ToInt32(txtSecond.Text)
            intThird = Convert.ToInt32(txtThird.Text)
            intFourth = Convert.ToInt32(txtFourth.Text)
        Catch ex As Exception
            MessageBox.Show("Enter in Digits!")
        End Try
        Dim intTotal as Integer = calcTotal(intFirst, intSecond, intThird, intFourth, intTotal)
        Me.lblTotal.Text = intTotal 'Shows as 0 at run-time
    End Sub

    Function calcTotal(ByVal intFirst As Integer, ByVal intSecond As Integer, ByVal intThird As Integer, ByVal intFourth As Integer, ByVal intTotal As Integer) As Integer
        Return intFirst + intSecond + intThird + intFourth
    End Function
End Class

answered Apr 18, 2013 at 21:05

Kenneth

28.8k7 gold badges65 silver badges85 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Kenneth Over a year ago

No problem. Please remember to upvote the answers that helped you and accept one of them.

Komlan · Accepted Answer · 2013-04-18 21:01:23Z

0

I am not sure what your problem is but your variable declaration are outside of your function . You should initialize them inside.

answered Apr 18, 2013 at 21:01

Komlan

1024 silver badges12 bronze badges

1 Comment

user2275554 Over a year ago

Thanks, that worked, but instead of declaring in the function, i declared in the event procedure, declaring in the function brought up a whole new set of issues.

Collectives™ on Stack Overflow

Functions in Visual Basic

2 Answers 2

1 Comment

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related