Not removing object from ArrayList

Question

In this code i need an object to be removed if a certain value is zero [Portfolio.total.get(k).get(c).current_quantity==0].

for(int k=0;k<Run_process.total_Agents;k++){
        for(int c=0;c<Portfolio.total.get(k).size();c++){
            if(Portfolio.total.get(k).get(c).current_quantity==0){
                System.out.println("delete Agent"+k+" "+Portfolio.total.get(k).get(c).stocks.stock_Id);
                Portfolio.total.get(k).remove(c);
                //remove from portfolio if there is no quantity
            }
        }
        //Portfolio.total.get(k).trimToSize();
    }
    //Portfolio.total.trimToSize();
    for(int k=0;k<Run_process.total_Agents;k++){
        for(int c=0;c<Portfolio.total.get(k).size();c++){
            if(Portfolio.total.get(k).get(c).current_quantity==0){
                System.out.println("still zero quantity Agent"+k+" "+Portfolio.total.get(k).get(c).stocks.stock_Id);
                //remove from portfolio if there is no quantity
            }
        }
        //Portfolio.total.get(k).trimToSize();
    }

The problem is that after i run this loop again to check if everything is ok BUT sometimes seems that 1-3 values although have [Portfolio.total.get(k).get(c).current_quantity==0] are still in the arraylist.The next time this code runs this object is properly deleted. To sum up some values are deleted the next time this code runs

jlordo · Accepted Answer · 2013-04-24 10:19:47Z

4

When you remove something, all following indexes decrease by 1. Incrementing your loop counter will skip the next element. They are the ones you are missing.

You need to do something like this:

Portfolio.total.get(k).remove(c); // you already have this line
c--;

Also, for the sake of readability I would prefer to use an Iterator and it's remove() method. This way you don't have to worry about indexes.

edited Apr 24, 2013 at 10:19

answered Apr 24, 2013 at 10:09

jlordo

37.9k7 gold badges63 silver badges84 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Marco Forberg · Accepted Answer · 2013-04-24 10:21:58Z

1

you should not delete items from an array while iterating over it forward. The Problem is probably because of two items with quantity directly one after another

e.g. item[0].current_quantity is 0 and item[1].current_quantity is 0

So if you iterate over your list, item[0] will be removed, item[1] will become item[0]. Now you increment your index, and skip your former item[1]. That is why it is still in your list.

If you really want to iterate over you list and delete items while iterating, you should do that backwards:

for(int c = Portfolio.total.get(k).size() - 1; c > 0;c--) {
    if(Portfolio.total.get(k).get(c).current_quantity==0) {
        Portfolio.total.get(k).remove(c);
    }
}

edited Apr 24, 2013 at 10:21

answered Apr 24, 2013 at 10:15

Marco Forberg

2,6445 gold badges24 silver badges33 bronze badges

1 Comment

jlordo Over a year ago

+1 The explanation is not 100% correct, but the idea and the code is good ;).

Dima · Accepted Answer · 2013-04-24 10:10:01Z

0

this is because you are skipping many items! when you remove an object, the list become smaller, so you are not checking the object that comes after this, every time after you remove an object, do a c--, it will solve the problem

answered Apr 24, 2013 at 10:10

Dima

8,6524 gold badges31 silver badges60 bronze badges

Comments

anubhava · Accepted Answer · 2013-04-24 10:20:07Z

0

You are accessing a list and inside the for loop removing an item from the same list. This can be problematic in many ways. You should better use Iterator for this:

 for(Iterator<YourObj> it=Portfolio.total.get(k).iterator(); it.hasNext();) {
      YourObj obj = it.next();
      if(obj.current_quantity==0){
            System.out.println("delete Agent"+k+" "+obj.stocks.stock_Id);
            it.remove();
            //remove from portfolio if there is no quantity
      }
 }

edited Apr 24, 2013 at 10:20

answered Apr 24, 2013 at 10:14

anubhava

790k67 gold badges603 silver badges671 bronze badges

Collectives™ on Stack Overflow

Not removing object from ArrayList

4 Answers 4

Comments

1 Comment

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related