Returning variable vs. Setting variable

Question

I'm considering the following approaches for class initialisation:

class Foo():
    def __init__(self):
        self.name = self.get_name()
    def get_name(self):
        return raw_input("Name: ")

class Foo():
    def __init__(self):
        self.name = ""
        self.get_name()
    def get_name(self):
        self.name = raw_input("Name: ")

class Foo():
    def __init__(self):
        self.name = raw_input("Name: ")

Is there any practical reason to opt for one over the others?

If not, which might be considered most Pythonic?

I wouldn't use a raw_input() inside an object though, but thats just me. Move it outside and supply the name when constructing your object. — Henrik Andersson
– Henrik Andersson, Commented Apr 24, 2013 at 12:35
So basically you're asking what's the best way to design a class Foo? Well, I guess the most pythonic would be bar, although baz can make sense too, if not quux. — georg
– georg, Commented Apr 24, 2013 at 12:46

Elmar Peise · Accepted Answer · 2013-04-24 12:42:36Z

2

If possible, input() the name outside of the class and pass it as a parameter to its __init__().
If this is not an option, I would go for the second alternative
I would rename get_name() to something like query_name() or input_name(). get_name() sounds like a getter (that gets the value of name) not like a setter or a routine that gets data from the user.

answered Apr 24, 2013 at 12:42

Elmar Peise

15.8k3 gold badges24 silver badges41 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Bruno A. · Accepted Answer · 2013-04-24 12:46:33Z

0

I don't like the idea of doing a raw input in the constructor, but after all, why not... I would prefer:

class Foo():
    def __init__(self):
        self.name = ""

    def prompt_name(self):
        self.name = raw_input("Name: ")

if __name__ == "__main__":
    aFoo = Foo()
    aFoo.prompt_name()

edited Apr 24, 2013 at 12:46

answered Apr 24, 2013 at 12:40

Bruno A.

1,88517 silver badges18 bronze badges

3 Comments

Aleph Over a year ago

Why not? Because application logic should be separated from getting input. (If this is possible.)

awesoon Over a year ago

get_name should return name, because it looks like a getter.

Bruno A. Over a year ago

+1 soon, agree that the method name is not my primary choice... Fixed in edit :)

Collectives™ on Stack Overflow

Returning variable vs. Setting variable

2 Answers 2

Comments

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related