PHP MYSQL SELECT BETWEEN DATE'S

Question

Hello i trying to select date from mysql between date's with this code:

if (empty($_GET['date-range1'])) { 
    $sql=mysql_query("SELECT * FROM sohy_raports ORDER BY ".$_GET['sort']." ".$_GET['ad']."");

} else {
$sql=mysql_query("SELECT * FROM sohy_raports WHERE date BETWEEN ".$_GET['date-range1']." AND ".$_GET['date-range2']." ORDER BY ".$_GET['sort']." ".$_GET['ad']."");
}

but with this code i can't select between date's only between id's. It can be from date format error Y-mm-dd ?

Thanks

Just a comment: you should write timestamps to the database, makes this question alot easier — Naruto
– Naruto, Commented May 27, 2013 at 8:20
What are the contents of $_GET['date-range1'] and $_GET['date-range2'] ? Also, your code is widely open to SQL injection attacks, you might want to read up on that if you plan on putting this code on the public internet. — Oldskool
– Oldskool, Commented May 27, 2013 at 8:21
What is the data type of the date column? What are the inputs? Why aren't you quoting those date values? Why aren't you using query parameters? — leftclickben
– leftclickben, Commented May 27, 2013 at 8:22
your code will never go for else condition if $_GET['date-range1'] is empty then how it will check for between and you missed comma between sort and ad.. — sAnS
– sAnS, Commented May 27, 2013 at 8:22

Borniet · Accepted Answer · 2013-05-27 08:22:14Z

2

Instead of

$sql=mysql_query("SELECT * FROM sohy_raports WHERE date BETWEEN ".$_GET['date-range1']." AND ".$_GET['date-range2']." ORDER BY ".$_GET['sort']." ".$_GET['ad']."");

do

$query = "SELECT * FROM sohy_raports WHERE date BETWEEN ".$_GET['date-range1']." AND ".$_GET['date-range2']." ORDER BY ".$_GET['sort']." ".$_GET['ad'];
echo $query;
$sql=mysql_query($query);

This will print out the query you are sending to your database, and will clear up alot of what might go wrong, and what exactly the date-format is you are using.

On the side, but no less important: - Don't use the mysql_* functions anymore, they are deprecated and unsafe. Switch to mysqli_* or PDO instead. - Never just use your GET variable (or POST) in your query, make sure you sanitize them first to prevent SQL injections.

answered May 27, 2013 at 8:22

Borniet

3,5564 gold badges26 silver badges33 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

PHP MYSQL SELECT BETWEEN DATE'S

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related