Error when trying upload file aspx / C#

Question

I have the following C# code:

string File = "../images/main/profile-icon.png";
if (Request.ContentLength != 0)
{
    int Size = Request.Files[0].ContentLength / 1024;
    if (Size <= 512)
    {

        string LocalFile = Request.Files[0].FileName;
        int dot = LocalFile.LastIndexOf('.');
        string FileType = LocalFile.Substring(dot + 1);
        if (FileType == "gif" || FileType == "jpg" || FileType == "png" || FileType == "GIF" || FileType == "JPG" || FileType == "PNG")
        {
            int LastIndex = LocalFile.LastIndexOf(@"\") + 1;
             File = LocalFile.Substring(LastIndex, LocalFile.Length - LastIndex);
            File = DateTime.Today.ToString();
            string Path = Server.MapPath(" ../images/profiles") + "..\\" + File;
            Request.Files[0].SaveAs(Path);
        }
    }
    else
    {
        Response.Write("The file is too big !");
    }
}
else
{
    Response.Write("Unknown Error !");
}

The problem is that in the third code line I get the following error:

Index was out of range. Must be non-negative and less than the size of the collection.

this is the form HTML source:

<form name="Register" runat="server" style="margin-top: 15px;" onsubmit="return validateProfile('Register');">
    <p>
       photo:
        <input type="file" name="File" style="margin-right:10px;" />
    </p>
</form>

My question is why and how can I fix this?

Wish for help, thanks!

In this line " int Size = Request.Files[0].ContentLength / 1024;" — Nave Tseva
– Nave Tseva, Commented Jun 4, 2013 at 14:41
you seem to be testing Request.ContentLength != 0 and then accessing Request.Files[0] I guess it is the issue — jbl
– jbl, Commented Jun 4, 2013 at 14:42

Dimitar Dimitrov · Accepted Answer · 2013-06-04 14:54:11Z

6

It appears that the Files array has no elements, maybe you can add a check:

if(Request.Files.Count > 0)
{
   // continue here ...
}

This probably means that you're not uploading the file correctly and it's missing from the request.

EDIT: Try to set the enctype="multipart/form-data" in your form tag. So it will become something like:

<form name="Register" runat="server" style="margin-top: 15px;" onsubmit="return validateProfile('Register');" enctype="multipart/form-data">

edited Jun 4, 2013 at 14:54

answered Jun 4, 2013 at 14:45

Dimitar Dimitrov

15.2k9 gold badges55 silver badges82 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Nave Tseva Over a year ago

Hi, thank you for the answer, but now it does not 'enter' into the condition although there is a file in the form, why?

Dimitar Dimitrov Over a year ago

It means you're not uploading it correctly. Maybe you can show us your markup.

Collectives™ on Stack Overflow

Error when trying upload file aspx / C#

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related