Make multiple PHP if statements more efficient

Question

I am starting out with PHP for a WordPress and have written some code to put some social network icons in the footer. The way I have done it works, I'm simply calling the content of social network URL stored in the DB and if there is something the icon/link in the footer. But looks very inefficient to me, here is the code, does anyone know how to make it more efficient.

      <?php 
        $social1 = of_get_option('fab_social_twitter_url');
        $social2 = of_get_option('fab_social_facebook_url');
        $social3 = of_get_option('fab_social_linkedin_url');            
      ?>



      <!-- divs for right social network icons column -->
      <div class="eight columns">
        <div class="social">
          <ul>

            <?php
                if(!empty($social1)) {
            ?>
                <li><a href="<?php echo of_get_option('fab_social_twitter_url'); ?>"><img src="<?php echo of_get_option('fab_social_twitter_icon'); ?>" alt="Follow us on Twitter"></a></li>
            <?php
             } 
            ?>

            <?php
                if(!empty($social2)) {
            ?>
                <li><a href="<?php echo of_get_option('fab_social_facebook_url'); ?>"><img src="<?php echo of_get_option('fab_social_facebook_icon'); ?>" alt="Follow us on Facebook"></a></li>
            <?php
             } 
            ?>            

            <?php
                if(!empty($social3)) {
            ?>                  
                <li><a href="<?php echo of_get_option('fab_social_linkedin_url'); ?>"><img src="<?php echo of_get_option('fab_social_linkedin_icon'); ?>" alt="Follow us on Linkedin"></a></li>
            <?php
             } 
            ?>            

          </ul>
        </div>
      </div>

Do you just think it is inefficient, or do you have evidence that it's inefficient? — user395760
– user395760, Commented Jun 29, 2013 at 14:30

Dave Chen · Accepted Answer · 2013-06-29 14:42:19Z

2

Maybe:

  <!-- divs for right social network icons column -->
  <div class="eight columns">
    <div class="social">
      <ul>
        <?php
            foreach (array("twitter","facebook","linkedin") as $option)
                ($tmp=of_get_option('fab_social_'.$option.'_url')) && (print('<li><a href="'.$tmp.'"><img src="'.of_get_option('fab_social_'.$option.'_icon').'" alt="Follow us on '.ucfirst($option).'"></a></li>'));
        ?>
      </ul>
    </div>
  </div>

edited Jun 29, 2013 at 14:42

answered Jun 29, 2013 at 14:34

Dave Chen

11k8 gold badges42 silver badges72 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Ayoub M. · Accepted Answer · 2013-06-29 14:34:31Z

1

From a performance point of view, I don't think that there is anything to optimize in here, three separate cases tested individually

answered Jun 29, 2013 at 14:34

Ayoub M.

4,83810 gold badges44 silver badges52 bronze badges

Comments

Lex Podgorny · Accepted Answer · 2013-06-29 14:38:34Z

  <?php 
    $social1 = of_get_option('fab_social_twitter_url');
    $social2 = of_get_option('fab_social_facebook_url');
    $social3 = of_get_option('fab_social_linkedin_url'); 

    $icon1 = of_get_option('fab_social_twitter_icon');
    $icon2 = of_get_option('fab_social_facebook_icon'); 
    $icon3 = of_get_option('fab_social_linkedin_icon');          
  ?>



  <!-- divs for right social network icons column -->
  <div class="eight columns">
    <div class="social">
      <ul>

        <?php if(!empty($social1)) { ?>
            <li>
               <a href="<?php echo $social1; ?>">
                  <img src="<?php echo $icon1; ?>" alt="Follow us on Twitter">
               </a>
            </li>
        <?php } ?>

        <?php if(!empty($social2)) { ?>
            <li>
               <a href="<?php echo $social2; ?>">
                  <img src="<?php echo $icon2; ?>" alt="Follow us on Facebook">
               </a>
            </li>
        <?php } ?>

        <?php if(!empty($social3)) { ?>
            <li>
               <a href="<?php echo $social3; ?>">
                  <img src="<?php echo $icon3; ?>" alt="Follow us on Linkedin">
               </a>
            </li>
        <?php } ?>   

      </ul>
    </div>
  </div>

Collectives™ on Stack Overflow

Make multiple PHP if statements more efficient

3 Answers 3

Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related