Add dynamic String in ListView in android

Question

I am able to add strings at run time in ListView. But I am only getting the last string data in the ListView. What is the cause of it? Here is my code.

 for (GraphUser user : users) { 
    ArrayList<String> arr = new ArrayList<String>(Arrays.asList(user.getName()));
                                                      ArrayAdapter<String> str = new ArrayAdapter<String>(getBaseContext(), android.R.layout.simple_list_item_1,arr); 
                                                      lv.setAdapter(str);
                                                      str.setNotifyOnChange(true);
    }

arr is within the scope of for. declare it outside the for loop — Raghunandan
– Raghunandan, Commented Jul 6, 2013 at 12:10

kaushal trivedi · Accepted Answer · 2013-07-06 12:14:48Z

1

Your code should be like this

ArrayList<String> arr = new ArrayList<String>
    for (GraphUser user : users) { 
        (arr.add(user.getName()));

        }

ArrayAdapter<String> str = new ArrayAdapter<String>(getBaseContext(), android.R.layout.simple_list_item_1,arr); 
                                                              lv.setAdapter(str);
                                                              str.setNotifyOnChange(true);

answered Jul 6, 2013 at 12:14

kaushal trivedi

3,4433 gold badges32 silver badges47 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

kaushal trivedi Over a year ago

You for loop to only fetch data,Setting adapter that much time only gives you costly memory operation.

Looking Forward Over a year ago

ArrayList<String> arr=null; for (GraphUser user : users) { arr = new ArrayList<String>(); arr.add(user.getName()); } ArrayAdapter<String> str = new ArrayAdapter<String>(getBaseContext(), android.R.layout.simple_list_item_1,arr); lv.setAdapter(str); str.setNotifyOnChange(true); Same problem...Only one data

kaushal trivedi Over a year ago

What i am suggesting is,assign memory to your list outside your for loop and use for loop to add data only.You can also put log in for loop to check if you are getting number of data or not.

bgauryy · Accepted Answer · 2013-07-06 13:23:18Z

I think that you should override the Adapter class and use changeList method to change the list :

    public void changeList(ArrayList<String>  objects){
        this.objects = objects;
        Collections.sort(objects);
        notifyDataSetChanged(); 
    }

objects: the new ArrayList

you should override the getView method:

    public View getView(int position, View convertView, ViewGroup parent) {         
        LayoutInflater inflater = (LayoutInflater) context.getSystemService(Context.LAYOUT_INFLATER_SERVICE);
        View rowView = inflater.inflate(R.layout.list_view_custom_layout, parent, false);
        TextView textView = (TextView)rowView.findViewById(R.id.label);
        textView.setText(objects.get(position));
        }       
        return rowView;
    }

list_view_custom_layout : custom Layout xml file ( contains some layout and a textView: "label" at this case )

worked for me.

Looking Forward · Accepted Answer · 2013-07-08 04:34:05Z

Finally got the solution...Working like a charm...

ArrayList<String> arr = null;
                                    arr = new ArrayList<String>();

                                    for (GraphUser user : users) {

                                        arr.add(user.getName());

                                    }

                                    ArrayAdapter<String> str = new ArrayAdapter<String>(
                                            getBaseContext(),
                                            android.R.layout.simple_list_item_1,
                                            arr);
                                    lv.setAdapter(str);
                                    str.setNotifyOnChange(true);

Collectives™ on Stack Overflow

Add dynamic String in ListView in android

3 Answers 3

3 Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

3 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related