Android NullPointerException in onCreate

Question

My project has a NullPointerException when creating the main activity. The main activity creates a fragment, which is where the exception lies. Here's the code for the part where it breaks: Fragment code:

Drawable red;

public void onCreate(Bundle savedInstanceState)
{
    super.onCreate(savedInstanceState);
    getActivity().setContentView(R.layout.main_layout);

    red = ((ImageView)this.getActivity().findViewById(R.drawable.icon_0)).getDrawable();
}

Activity code:

private ProblemFragment problemFrag;

protected void onCreate(Bundle savedInstanceState)
{
    super.onCreate(savedInstanceState);
    setContentView(R.layout.main_layout);   
    problemFrag = new ProblemFragment();

    ActionBar bar = getSupportActionBar();
    bar.setNavigationMode(ActionBar.NAVIGATION_MODE_TABS);

    Tab tab = bar.newTab().setText("Problem Fragment").setTabListener(new MyTabListener(this, dashboardFrag));

    bar.setHomeButtonEnabled(true);
}

It crashes when it's running past the red drawable. Is this because of the "getActivity()" line? It is imperative to have these values instantiated immediately, but I can't think of a way to load them up without using findById. If it helps, they are PNG files in the res folder.

Do you call setContentView in your Activity before showing the Fragment? — FD_
– FD_, Commented Jul 30, 2013 at 17:00

unmultimedio · Accepted Answer · 2013-07-30 17:00:55Z

2

Try this:

Drawable red = getResources().getDrawable(R.drawable.icon_0);

For all your resources that are not declared views in your xml

answered Jul 30, 2013 at 17:00

unmultimedio

1,2543 gold badges13 silver badges40 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

TN888 · Accepted Answer · 2013-07-30 17:03:59Z

1

Best solution in that situation is using getResources().getDrawable() methods like that :

red = getActivity().getResources().getDrawable(R.drawable.icon_0);

Please use it to every drawables, etc. in your res folder.

answered Jul 30, 2013 at 17:03

TN888

7,7499 gold badges52 silver badges85 bronze badges

4 Comments

Aneesh Ashutosh Over a year ago

I did that, and now I'm getting an IllegalStateException stating that the fragment is not properly attached to the activity.

Aneesh Ashutosh Over a year ago

The getActivity was what was causing the NullPointerException earlier though... :/

Aneesh Ashutosh Over a year ago

Yeah, it caused a NullPointerException.

Aneesh Ashutosh Over a year ago

Never mind, fixed it myself. I made red a default variable and then initialized it from the main activity's onCreate.

Collectives™ on Stack Overflow

Android NullPointerException in onCreate

2 Answers 2

Comments

4 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

4 Comments

Your Answer

Sign up or log in

Post as a guest

Related