javascript change color of textbox

Question

I have this code but it just wont work. what could the problem be? Is my syntax wrong or is the whole method wrong?

<input checked="checked" class="form-field" id="IsCurrentlySmokingrightNej" name="IsCurrentlySmokingright" type="radio" value="Nej">
<input class="form-field" id="IsCurrentlySmokingrightJa" name="IsCurrentlySmokingright" type="radio" value="Ja">
    <input id="IsCurrentlySmokingrighttextbox" name="IsCurrentlySmokingright" type="text" style="background-color: rgb(0, 255, 0); float: right; width: 50px;">

javascript:

 $(document).on("change", "IsCurrentlySmokingrightNej", function() {
    var elem = document.getElementById("IsCurrentlySmokingrightNej");
    var ele = $("#IsCurrentlySmokingrighttextbox");
    if (elem.checked) {
        ele.css("background-color", "rgba(0, 255, 0, 1)");
        ele.css("float", "right");
        ele.css("width", "50px");

    }
});

   $(document).on("change", "IsCurrentlySmokingrightJa", function() {
        var elem = document.getElementById("IsCurrentlySmokingrightJa");
        var ele = $("#IsCurrentlySmokingrighttextbox");
        if(elem.checked){
            ele.css("background-color", "rgba(255, 0, 0, 1");//röd
            ele.css("float", "right");
            ele.css("width", "50px");
        }

});

Add a # before IsCurrentlySmokingrightJa, so $(document).on("change", "#IsCurrentlySmokingrightJa"... — putvande
– putvande, Commented Jul 31, 2013 at 12:40

bipen · Accepted Answer · 2013-07-31 12:40:09Z

3

you missed # in front of id selector

 $(document).on("change", "#IsCurrentlySmokingrightNej", function() {
                      //---^---here

same goes for the rest..

answered Jul 31, 2013 at 12:40

bipen

36.6k9 gold badges51 silver badges62 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Code Lღver · Accepted Answer · 2013-07-31 12:41:46Z

1

You need to give the # or . if it is id then # and if class name then .

$(document).on("change", "#IsCurrentlySmokingrightNej", function() {
                          ^^^ # here as it is id

And one more thing:

var elem = document.getElementById("IsCurrentlySmokingrightNej");

Why are you using this line even though you are not using it anywhere.

answered Jul 31, 2013 at 12:41

Code Lღver

15.6k16 gold badges61 silver badges75 bronze badges

2 Comments

Daniel Gustafsson Over a year ago

I acctually used that code before but i have modified the code a couple of times so now it was only in the way of the code. Thanks!

Code Lღver Over a year ago

@DanielGustafsson ok, just to know to understand the question properly. well no prob.

Collectives™ on Stack Overflow

javascript change color of textbox

2 Answers 2

Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related