Can't get if statement to compare two strings in javascript

Question

In my code when i equals 5 myDate should be equal to it. The alert shows me that they are the same. I can never get the function to return 1;

function checkForHoliday(date) {
    var myDate = new Date(date);
    myDate = myDate.getMonth() + "/" + myDate.getDate() + "/" + myDate.getFullYear();

    alert(myDate + "\n" + holidays[5]);

    for (i = 0; i <= 9; i++) {
       if (myDate == holidays[i]) {
           return 1;
           alert("got it");
       }       
    }

    return 0;
}

This is what the string in the array looks like:

year = 2013
holidays[5] = "7/2/" + year

My alert shows me this: enter image description here

@SimonAndréForsberg: It looks like he's converting it to a string. — gen_Eric
– gen_Eric, Commented Aug 28, 2013 at 17:44
BTW, in the future I recommend using console.log for this kind of "printf debugging". Learning to use the development tools and debugger in your favourite browser also helps a ton. — hugomg
– hugomg, Commented Aug 28, 2013 at 17:44
You are returning 1 before you execute your alert statement. Try returning 1 after you do you alert so you can tell if your condition is met in the if statement. — Alex Funk
– Alex Funk, Commented Aug 28, 2013 at 17:46
I'd recommend you to convert the holidays and the dates to a unix timestamp and to compare them both like you're doing now, that way you won't have to mess with strings. — Ignacio Belhot Colistro
– Ignacio Belhot Colistro, Commented Aug 28, 2013 at 17:46

vegasje · Accepted Answer · 2013-08-28 18:00:35Z

I have run your code locally, and have it working.

I'm going to guess that your issue stems from the fact that Date.getMonth() returns month numbers where January === 0. That throws a lot of people off.

To recreate your code, I simply used Chrome's console. I also changed your alert to a console.log to save myself the hassle of using alert.

Here's the code:

function checkForHoliday(date) {
  var myDate = new Date(date);
  myDate = myDate.getMonth() + "/" + myDate.getDate() + "/" + myDate.getFullYear();

  console.log(myDate + "\n" + holidays[5]);

  for (i = 0; i <= 9; i++) {
    if (myDate == holidays[i]) {
      return 1;
    }
  }

  return 0;
}

And a fake holiday array:

holidays = [0,1,2,3,4,'7/2/2013']

(The 7 here actually corresponds to August)

Upon running checkForHoliday('8/2/2013'), the console reports back a response of 1. The code successfully matches the date.

If you actually intended for holiday[5] to represent July 2nd, 2013, you'll need to set holiday[5] = '6/2/2013'.

JNL · Accepted Answer · 2013-08-28 17:49:44Z

0

Try Using this,

 <script type="text/javascript">

    var startYear = parseInt(document.getElementById('startYear'), 10);
    var startMonth = parseInt(document.getElementById('startMonth'), 10) - 1; 
    var startDay = parseInt(document.getElementById('startDay'), 10);
    var myDate = new Date(startYear, startMonth, startDay);

</script>

answered Aug 28, 2013 at 17:49

JNL

4,70120 silver badges29 bronze badges

Comments

meghamind · Accepted Answer · 2013-08-28 17:50:16Z

0

Convert the date object to string in desired format. Use triple equals operator to test equality.

Try:

if (myDate.toLocaleDateString() === holidays[i]) {
    return 1;
    alert("got it");
}

answered Aug 28, 2013 at 17:50

meghamind

964 bronze badges

Collectives™ on Stack Overflow

Can't get if statement to compare two strings in javascript

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related