Here's my function:
CSS_Left = '450px';
CSS_Left.replace('px', '');
alert(CSS_Left);
It returns '450px'
Here's an example:
I want it to replace 'px' with nothing.
-
Is it really so hard to google "javascript replace" and look at, well, nigh on any of the results? They will show the proper use of this method.MDEV– MDEV2013-09-05 23:20:49 +00:00Commented Sep 5, 2013 at 23:20
-
possible duplicate of Does javascript have a method to replace part of a string without creating a new string?ephemient– ephemient2013-09-05 23:55:43 +00:00Commented Sep 5, 2013 at 23:55
-
Better duplicate: stackoverflow.com/questions/1433212/replace-method-doesnt-workBergi– Bergi2014-05-21 22:16:08 +00:00Commented May 21, 2014 at 22:16
Add a comment
|
4 Answers
In JavaScript, Strings are immutable.
All types except objects define immutable values. Specifically, strings are immutable (unlike in C for instance).
So, str.replace returns a new string. Try this instead:
CSS_Left = CSS_Left.replace('px', '');
Or if you don't want to overwrite the original string, just do it in the alert call
alert(CSS_Left.replace('px', ''));
It's worth noting that .replace can also take a regexp. Though it's not necessary in your case, you could do something like this to achieve the same result
CSS_Left = CSS_left.replace(/px$/, '');
3 Comments
JVE999
I can't believe I missed that X( . Thanks a lot! That was confusing me.
LexLythius
Moreover, String objects are immutable. You cannot edit them, only create modified new instances.
Mulan
@LexLythius, I'll make a note. Thanks for your review.
Because .replace() return a new string. If you want to update the old string you should write:
CSS_Left = CSS_Left.replace('px', '');
Comments
I am not sure, but the function replace() creates a new variable. Try this :
var CSS_Left = '450px';
CSS_Left = CSS_Left.replace('px', '');
alert(CSS_Left);
Comments
The output of the replace call needs to be reassigned to CSS_Left
Comments
