PHP code executes before submit

Question

I made a login form, I had a lot of other problems with it and now I found out that the PHP code was being executed before the submit. HOW can the problem be solved? Since PHP does not support onclick events(which anyway sucks!), I don't see any solution that I know!

Code:

//Get the form with POST
$user = mysql_real_escape_string($_POST['user']);
$password = mysql_real_escape_string($_POST['pass']);



$usernames=mysql_query("SELECT * FROM user_info WHERE Username='" . $_POST['user'] . "' AND Password='" . $_POST['pass'] . "'");
if(!$usernames){echo mysql_error();}

$count=mysql_num_rows($usernames);
if(!$count){echo mysql_error();}

//If $count is equal to one, register the user and redirect him to his page, or else   echo him that his info is wrong
if($count === 1) {
$_SESSION['code'] = "titan";
$_SESSION['ande'] = $user;
$_SESSION['password'] = $password;
header("location: home.php");}
else {
echo "<p style='color:red;text-align:center;'>Wrong username or password!</p>";}

PHP does not allow functions? I've been doing it wrong all these years! — John Conde
– John Conde, Commented Sep 23, 2013 at 17:52
Guys, all the snark is unhelpful and only serves to make stack overflow look like it's hostile to beginners. It's self-evident from the code that this is someone's first "my form in php" code. You guys should be better than this. — Wing
– Wing, Commented Sep 23, 2013 at 18:09

John Conde · Accepted Answer · 2013-09-23 17:53:12Z

5

Wrap the code that is supposed to be executed after the form submission in an IF statement that checks to see if the form is submitted:

if ('POST' === $_SERVER['REQUEST_METHOD'])
{
    // your code goes here
}

answered Sep 23, 2013 at 17:53

John Conde

220k100 gold badges464 silver badges504 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

MD SHAHIDUL ISLAM · Accepted Answer · 2013-09-24 15:56:08Z

3

Check if form is submitted

if(isset($_POST['user'])) {

   //Your php code goes here

}

Based on your comment I extended this answer

Just place all code in this condition which you have sent in your question

if(isset($_POST['user']))
{

    //Get the form with POST
    $user = mysql_real_escape_string($_POST['user']);
    $password = mysql_real_escape_string($_POST['pass']);



    $usernames=mysql_query("SELECT * FROM user_info WHERE Username='" . $_POST['user'] . "' AND Password='" . $_POST['pass'] . "'");
    if(!$usernames){echo mysql_error();}

    $count=mysql_num_rows($usernames);
    if(!$count){echo mysql_error();}

    //If $count is equal to one, register the user and redirect him to his page, or else   echo him that his info is wrong
    if($count === 1) {
    $_SESSION['code'] = "titan";
    $_SESSION['ande'] = $user;
    $_SESSION['password'] = $password;
    header("location: home.php");}
    else {
    echo "<p style='color:red;text-align:center;'>Wrong username or password!</p>";}

}

edited Sep 24, 2013 at 15:56

answered Sep 23, 2013 at 17:54

MD SHAHIDUL ISLAM

14.5k6 gold badges84 silver badges93 bronze badges

2 Comments

user2758781 Over a year ago

It didn't work! Maybe I'm doing it wrong: Should I place this code as a new one or should I replace the old condition with this one?

MD SHAHIDUL ISLAM Over a year ago

You will get idea, see login.php page script from this answer stackoverflow.com/a/18979508/2459296

user2758781 · Accepted Answer · 2013-09-25 15:55:56Z

0

What I DID NOT tell you was that the PHP code was in the same file with the form and the rest of HTML... I tried to remake the code in AJAX, (it didn't work =(, but it still helped!) and for that I moved the PHP code inside another file (Login_engine.php). And that was it! Sure, there still is a tiny problem: now, the red text is displayed inside Login_engine.php... That sucks!

answered Sep 25, 2013 at 15:55

user2758781

Collectives™ on Stack Overflow

PHP code executes before submit

3 Answers 3

Comments

2 Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related