Android ListView Click Listener does not work

Question

I found this excellent tutorial on using icons for ListView items. http://www.debugrelease.com/2013/06/24/android-listview-tutorial-with-images-and-text/

I followed it exactly, and my ListView layout looks great! BUT...I can't get the onclick listener working for the ListView. I'm just stuck on the ListView screen. Here's my Main.java code where I put the listener. I'm using Deepak's (from above link) Item and ItemAdapter classes exactly with no changes. I only changed his Model class to put in my own icon file names. What am I missing?

import android.os.Bundle;
import android.app.Activity;
import android.content.Intent;
import android.view.Menu;
import android.view.View;
import android.widget.ListView;

public class Main extends Activity {

ListView listView;

@Override
public void onCreate(Bundle savedInstanceState) {

    super.onCreate(savedInstanceState);
    setContentView(R.layout.main);

    Model.LoadModel();
    listView = (ListView) findViewById(R.id.listView);
    String[] ids = new String[Model.Items.size()];
    for (int i= 0; i < ids.length; i++){

        ids[i] = Integer.toString(i+1);
    }

    ItemAdapter adapter = new ItemAdapter(this,R.layout.row, ids);
    listView.setAdapter(adapter);
    listView.setOnItemClickListener(new OnItemClickListener(){

        @Override
        public void onListItemClick(ListView l, View v, int position, long id){

            Intent i;
            switch (position) {
            case 0:
                i = new Intent(this, AnglesConvert.class);
                startActivity(i);
                break; 
            case 1:
                i = new Intent(this, AreaConvert.class);
                startActivity(i);
                break;
        }
    });    

}

Thanks Ankur, I revised the Main.java file as above. Now I got red squiggles under Everything. Not sure what I'm doing wrong.

rcbevans · Accepted Answer · 2013-10-09 19:35:57Z

2

You need to call

listview.setOnClickListener(onListItemClick()) ;

After

listview.setAdapter(adapter) ;

answered Oct 9, 2013 at 19:35

rcbevans

9,1426 gold badges32 silver badges47 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Ankur Jain · Accepted Answer · 2013-10-09 19:42:27Z

2

Use have not attached listener to it, Use this

listview.setOnItemClickListener(new onItemClickListener(){

@Override
protected void onListItemClick(){

//Do stuff
}
});

answered Oct 9, 2013 at 19:42

Ankur Jain

909 bronze badges

2 Comments

user2268716 Over a year ago

Maybe this should work, but it doesn't. Please see my new Main.java file above. Now it has red squiggles under everything. Any idea what I did wrong?

Ankur Jain Over a year ago

Is there only two items (rows) in your list?

blganesh101 · Accepted Answer · 2013-10-09 19:36:32Z

1

For onListItemClick to work. extend your class with ListActivity.

public class Main extends ListActivity {

Refer standard example

http://developer.android.com/guide/topics/ui/layout/listview.html

answered Oct 9, 2013 at 19:36

blganesh101

3,7151 gold badge26 silver badges44 bronze badges

Collectives™ on Stack Overflow

Android ListView Click Listener does not work

3 Answers 3

Comments

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related