Refactoring: Simple regex

Question

lLets say I have the following: $string = 'New+York-NY and where + is I want a \s and where - is I want ', '. The formatted string would appear as New York, NY.

Here is my code: $string = 'New+York-NY';

    $formattedLocation = preg_replace('/[+]/', ' ', $location);
    $formattedLocation = preg_replace('/-/', ', ', $formattedLocation);

    echo $formattedLocation;

This code works. However it is ugly and I would like to refactor it (if possible). I tried:

    $formattedLocation = preg_replace('/[+]/', ' ', $location) && preg_replace('/-/', ', ', $location);

This however doesn't work and is also still ugly. Should I be using a different function? Or should my regex be different? Please don't suggest wrapping it in a custom function (that's not the answer I'm looking for).

Thanks

Why do you consider your initial code ugly? It's readable and doesn't get more effective as long as you're using regexp. — Johannes H.
– Johannes H., Commented Nov 14, 2013 at 2:38
for these kind of literal replacement you don't need to use preg_replace, use only str_replace that is faster. — Casimir et Hippolyte
– Casimir et Hippolyte, Commented Nov 14, 2013 at 2:40
I think it's ugly because it is repetitive. I would Like to shorten it without sacrificing simplicity. (if possible) — MrPizzaFace
– MrPizzaFace, Commented Nov 14, 2013 at 2:41
Wrap the replacement inside a function - that'S the usual way to ensure DRY. Or just don't use preg_repalce at all, see @p.s.w.g's answer. — Johannes H.
– Johannes H., Commented Nov 14, 2013 at 2:42

p.s.w.g · Accepted Answer · 2013-11-14 02:40:43Z

1

For something this simple do you really need to use regular expressions? Try using str_replace:

$formattedLocation = str_replace(array('+', '-'), array(' ', ', '), $location);

answered Nov 14, 2013 at 2:40

p.s.w.g

150k31 gold badges307 silver badges339 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Refactoring: Simple regex

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related