JS Form Validation - Submit Button does nothing

Question

I'm trying to validate my form, and the first alert works. But then when the user fills in correct data and clicks submit, the form does not submit anymore. Any help is appreciated, thanks!

<form name="register" action="register.php" onsubmit="return validateForm()" method="post">

// form stuff

function validateForm() {
if (!checkName() || !checkEmail()) {
    return false;
} else {
    return true;
}
}

function checkName() {
var name=document.forms["register"]["name"].value;
if (name==null || name=="") {
    alert("Please fill out your name");
    return false;
}
}

function checkEmail() {
var email=document.forms["register"]["email"].value;
var atpos=email.indexOf("@");
var dotpos=email.lastIndexOf(".");
if (atpos<1 || dotpos<atpos+2 || dotpos+2>=email.length) {
    alert("Not a valid e-mail address");
    return false;
}
}

Have you looked at the jQuery validation plugin? It's very widely used and will likely save you a load of pain. — jameslafferty
– jameslafferty, Commented Nov 17, 2013 at 23:39
inline javascript is awful. Please don't do that. You really ought to let javascript handle the whole process using ajax. — m59
– m59, Commented Nov 17, 2013 at 23:41
Thank you both for your comments! I have not tried either of those options, but I thought for my small projects I would not need much. However, I do think I'll look those both up to try for this project, and to help me in later ones. Thanks! — user3002809
– user3002809, Commented Nov 17, 2013 at 23:54

jameslafferty · Accepted Answer · 2013-11-17 23:47:49Z

1

You need checkEmail and checkName to return true when the email or name is present. What you've got now returns undefined.

Here is a fiddle showing the solution and here are the two functions rewritten:

function checkName() {
    var name = document.forms["register"]["name"].value;
    if (name == null || name == "") {
        alert("Please fill out your name");
        return false;
    }
    return true;
}

function checkEmail() {
    var email = document.forms["register"]["email"].value;
    var atpos = email.indexOf("@");
    var dotpos = email.lastIndexOf(".");
    if (atpos < 1 || dotpos < atpos + 2 || dotpos + 2 >= email.length) {
        alert("Not a valid e-mail address");
        return false;
    }
    return true;
}

I do ultimately think you'll be happier if you wind up going to jQuery Validation, though.

answered Nov 17, 2013 at 23:47

jameslafferty

2,1822 gold badges21 silver badges25 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

JS Form Validation - Submit Button does nothing

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related