remove duplicates in a char array of pointers

Question

I have array of pointers in liste_tmp with values "123" , "456" , "123"

Declaration :

char  *no_rlt_liste[5] , *liste_tmp[5]; int i, j, count =0;
for (i = 0 ; i < n; i++){
    for ( j= 0 ; j< count; j++){
            if (liste_tmp[i] == no_rlt_liste[j]){
                    break;
            }
            if (j == count){
                    no_rlt_liste[count]  = liste_tmp[i];
                    printf(" ENTER\n");
                    count++;
            }
    }
}
for (i = 0 ; i < count; i++)
    printf("Final result %s\n", no_rlt_liste[i]);

the above code doesn't produce result. not able to identify the bug. any help? Thanks

Are you familiar with strcmp()? And I assume you clipped out the code where you actually properly initialize liste_tmp[] and no_rlt_liste[] ? — WhozCraig
– WhozCraig, Commented Nov 29, 2013 at 8:11
You will probably need to use strcmp() to compare strings, probably in place of if (liste_tmp[i] == no_rlt_liste[j]). — Jonathan Leffler
– Jonathan Leffler, Commented Nov 29, 2013 at 8:19

user694733 · Accepted Answer · 2013-11-29 08:11:43Z

3

Your for loops never run because of the condition j< count, and you have set count =0.

answered Nov 29, 2013 at 8:11

user694733

16.3k4 gold badges48 silver badges75 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

WhozCraig Over a year ago

While presumptive on my part, I've a suspicion the code posted has all of the initialization (the arrays, count, etc) omitted. Still, this seems correct, so +1, though I still think the comparison is wrong.

user1781290 · Accepted Answer · 2013-11-29 08:13:42Z

2

You initialize count to 0 which cause the inner for loop to not execute (since j < 0 is always false), thus your whole loop doing nothing.

for (i = 0 ; i < n; i++)
{
  int flag = 0;
  for (j= 0; j< count; j++)
  {
    if (liste_tmp[i] == no_rlt_liste[j])
    {
      flag = 1
      break;
    }
  }
  if (!flag)
  {
      no_rlt_liste[count]  = liste_tmp[i];
      printf(" ENTER\n");
      count++;
  }
}

Also, be aware that you need to use strcmp if you do not want to compare the char-pointers, but their contents instead:

   if (strcmp(liste_tmp[i], no_rlt_liste[j]) == 0)
   {
      flag = 1
      break;
   }

answered Nov 29, 2013 at 8:13

user1781290

2,93425 silver badges28 bronze badges

Collectives™ on Stack Overflow

remove duplicates in a char array of pointers

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related