Angular only pulling last JSON object

Question

Trying to get all JSON objects in an array. It's only returning the last one.

Here's a sample of my JSON:

{
    "manufacturer":{
        "name": "manufacturername",
        "cameras": [
            {
                "name": "sdfsdfsd",
                "type": "Audio device",
                "resolution": "Unknown",
                "channels": "1"
            }
        ]
    },
    "manufacturer":{ 
        "name": "manufacturername2",
        "cameras": [
        {
            "name": "sdfsdf",
            "type": "Camera",
            "resolution": "720P/1.3MP",
            "channels": "2"
        },
        {
            "name": "D12",
            "type": "Camera",
            "resolution": "1080P/3MP",
            "channels": "1"
        }
]
}}

It is valid JSON.

Here's how I'm calling it:

    //Get Manufacturer data
$http.get('data2.json').success(function(data) {

    $scope.maninfo = data;
    console.log($scope.maninfo);
});

The actual array is much longer - and it's just returning the last Object for some reason.

You want [] brackets around it, not {}.

Zack Argyle
– Zack Argyle

2013-12-03 20:27:58 +00:00
Commented Dec 3, 2013 at 20:27 — Zack Argyle
– Zack Argyle, Commented Dec 3, 2013 at 20:27

15ee8f99-57ff-4f92-890c-b56153 · Accepted Answer · 2016-01-07 14:12:48Z

What you have is valid JSON, but it doesn't correctly express your intent. "manufacturer" (or "name", or "cameras") isn't a type name, it's a unique key into a collection of named values -- dictionary, map, hash, whatever(1). JSON data structures are just a subset of JavaScript object literal declarations (hence the name: JavaScript Object Notation).

So the example above is not an array, it's two successive value assignments to the "manufacturer" property of the same parent object. The parser is assigning the first one to the "manufacturer" property, then replacing that with the second (and in your original, larger) "array", it's then replacing that with the third, and so on.

The "cameras" properties in the manfacturer objects are properly functioning arrays. Just do the same at the higher level -- something more like this:

{
    "manufacturers":
    [
        {
            "name": "manufacturername",
            "cameras": [
                {
                    "name": "sdfsdfsd",
                    "type": "Audio device",
                    "resolution": "Unknown",
                    "channels": "1"
                }
            ]
        },
        { 
            "name": "manufacturername2",
            "cameras": [
                {
                    "name": "sdfsdf",
                    "type": "Camera",
                    "resolution": "720P/1.3MP",
                    "channels": "2"
                },
                {
                    "name": "D12",
                    "type": "Camera",
                    "resolution": "1080P/3MP",
                    "channels": "1"
                }
            ]
        }
    ]
}

(1) Dictionary, map, hash -- or "associative array". But I didn't want to call it any kind of "array" in that paragraph, because the whole point is it's not the other kind of array.

This was perfect. Thanks. I now also have a much better understanding of the structure of JSON depending on intent.

Collectives™ on Stack Overflow

Angular only pulling last JSON object

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related