cannot find error in mysql code

Question

I've been staring at this for ages and i cannot figure out what is wrong with this code

CREATE TABLE `faults` (
`id` int(11) NOT NULL AUTO_INCREMENT,
`Reported_by` varchar(30) NOT NULL,
`Company` varchar(20) NOT NULL,
`Reporters_email` varchar(100) NOT NULL,
`Department` varchar(20) NOT NULL,
`Error_Detail` text,
`user_id` INT(11) NOT NULL,
PRIMARY KEY (`id`),
KEY `user_id` (`user_id`),
CONSTRAINT `faults_fk_1` FOREIGN KEY (`user_id`) REFERENCES `users` (`id`);

the fault is on the last line

this is the error it gives me which isn't very helpful:

1064 - You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '' at line 11

can anybody spot my mistake??

no closing bracket? CREATE TABLE faults (...

user2363448
– user2363448

2013-12-16 16:04:34 +00:00
Commented Dec 16, 2013 at 16:04 — user2363448
– user2363448, Commented Dec 16, 2013 at 16:04
Prob the needed parenthesis REFERENCES 'users' ('id'));

MikeSmithDev
– MikeSmithDev

2013-12-16 16:06:01 +00:00
Commented Dec 16, 2013 at 16:06 — MikeSmithDev
– MikeSmithDev, Commented Dec 16, 2013 at 16:06
@ldrumm that's an answer, not a comment ;-).

Bart Friederichs
– Bart Friederichs

2013-12-16 16:07:31 +00:00
Commented Dec 16, 2013 at 16:07 — Bart Friederichs
– Bart Friederichs, Commented Dec 16, 2013 at 16:07

Kermit · Accepted Answer · 2013-12-16 16:08:47Z

1

Sometimes, a little formatting helps find your mistake (missing closing parenthesis). I would also recommend being more consistent with your column naming. Don't mix capitalization with lower case and underscores. I would suggest camel case.

CREATE TABLE `faults` 
  ( 
     `id`              INT(11) NOT NULL auto_increment, 
     `reported_by`     VARCHAR(30) NOT NULL, 
     `company`         VARCHAR(20) NOT NULL, 
     `reporters_email` VARCHAR(100) NOT NULL, 
     `department`      VARCHAR(20) NOT NULL, 
     `error_detail`    TEXT, 
     `user_id`         INT(11) NOT NULL, 
     PRIMARY KEY (`id`), 
     KEY `user_id` (`user_id`), 
     CONSTRAINT `faults_fk_1` FOREIGN KEY (`user_id`) REFERENCES `users` (`id`) 
  ); <-- missing

answered Dec 16, 2013 at 16:08

Kermit

34.1k13 gold badges89 silver badges121 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Steve Over a year ago

Thanks its always something so simple, and got rid of the caps thanks for advice on caps

score 1 · Accepted Answer · 2013-12-16 16:16:27Z

1

It appears you have missed a closing bracket. CREATE TABLE faults ( is not closed before your terminating semicolon on line 11 as MySQL is complaining about.

Add the closing bracket and you should be fine: REFERENCES 'users' ('id'));

To more easily notice errors such as these, you should use a text editor that supports bracket and brace matching. All good programmer's editors will do this.

edited Dec 16, 2013 at 16:16

answered Dec 16, 2013 at 16:09

user2363448

5 Comments

user2363448 Over a year ago

@MikeSmithDev according to whom? They are synonymous as far as I can tell.

Kermit Over a year ago

@MikeSmithDev Wikipedia would disagree with you.

MikeSmithDev Over a year ago

@ldrumm I see. I've always associated with [ but guess I'm wrong. Learn something every day.

user2363448 Over a year ago

The square bracket [ can be called 'bracket', but on its own, the word bracket is synonymous with both mathematical parentheses as well as square brackets used for indices in most prgramming languages. I agree that in the context of my answer this seems a bit flowery, so I'll edit my post.

Steve Over a year ago

i usually use n++ when editing but was using phpmyadmin and also working off putty as was meant to be a quick edit.

Collectives™ on Stack Overflow

cannot find error in mysql code

2 Answers 2

1 Comment

5 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

5 Comments

Your Answer

Sign up or log in

Post as a guest

Related