Update query updates all rows in database instead of particular row

Question

I am new to Zend framework and I am trying to update data in database and grid, but instead of updating particular row all rows are getting updated. please help me with this.

Here is my controller code.

public function editAction()
{

$form = new Application_Form_user();
$this->view->form = $form;

if($this->getRequest()->isPost())
{

$formData= $this->getRequest()->getPost();

if($form->isvalid($formData))
{
    $client= new Application_Model_DbTable_Client();
    $firstname = $formData['firstname'];
    $lastname = $formData['lastname'];
    $email = $formData['email'];

    $client->updateClient('Id',$firstname,$lastname,$email);

    $this->_helper->redirector('index');
}
else 
{
    $form->populate($formData);

}
}
else
{

    $id=$this->getRequest()->getparam('id');
    if($id>0)
    {

        $client= new Application_Model_DbTable_Client();
        $clients = $client->getClient('Id');

        $form->populate($clients[0]);
    }
}
}

And here is my model code.

public function updateClient($id,$firstname,$lastname,$email)
{
    $data=array('firstname'=>$firstname,
              'lastname'=>$lastname,
               'email'=>$email);
 $this->update($data,"Id=$id");
}

stackoverflow.com/questions/4097234/…

Nouphal.M
– Nouphal.M

2013-12-21 09:55:33 +00:00
Commented Dec 21, 2013 at 9:55 — Nouphal.M
– Nouphal.M, Commented Dec 21, 2013 at 9:55

user229044 · Accepted Answer · 2013-12-21 09:59:31Z

1

  $client->updateClient('Id',$firstname,$lastname,$email)

You're passing the literal string 'Id' as the $id parameter to updateClient. Inside updateClient, you build a where condition with "Id=$id". Your where condition becomes where Id=Id, which is true for every record, so every record is updated.

You need to pass a variable containing the actual ID of the record you want to update.

answered Dec 21, 2013 at 9:59

user229044♦

241k41 gold badges347 silver badges350 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Andy Librian · Accepted Answer · 2013-12-21 10:48:16Z

0

try to change your code, so it looks like this:

if($form->isvalid($formData))
{
    $client= new Application_Model_DbTable_Client();
    $firstname = $formData['firstname'];
    $lastname = $formData['lastname'];
    $email = $formData['email'];

    $id=$this->getRequest()->getparam('id'); // define your id

    $client->updateClient($id,$firstname,$lastname,$email); // here, change Id into proper $id

    $this->_helper->redirector('index');
}

answered Dec 21, 2013 at 10:48

Andy Librian

9135 silver badges12 bronze badges

4 Comments

Tuhin Over a year ago

Thanks for your reply andylibrian. I changed my Id into $id but it gives an error "undefined variable".

Andy Librian Over a year ago

Have you added following line? $id=$this->getRequest()->getparam('id'); // define your id That code defines your id.

Tuhin Over a year ago

Sorry I didn't had defined id, now it's working properly. Thanks a lot for helping me with this.

Andy Librian Over a year ago

You're welcome. If your problem has been resolved, you may want to accept my answer so others can see that this question has been answered. ;-)

Collectives™ on Stack Overflow

Update query updates all rows in database instead of particular row

2 Answers 2

Comments

4 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

4 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related